Skip to content
Permalink
Browse files

chore: enable AtclauseOrder checkstyle rule (#1417)

* chore: enable AtclauseOrder checkstyle rule

enable AtclauseOrder checkstyle rule + fix violations + update checkstyle lib and plugin

* chore: enable AtclauseOrder checkstyle rule

move .editorconfig to upper level
  • Loading branch information...
AlexElin authored and davecramer committed Feb 24, 2019
1 parent 6a0960a commit 7ae1e833cda9966c79fc84ebe633f8492b3e5f3d
File renamed without changes.
@@ -33,7 +33,7 @@
<jdbc.specification.version>4.2</jdbc.specification.version>
<jdbc.specification.version.nodot>42</jdbc.specification.version.nodot>
<skip.assembly>false</skip.assembly>
<checkstyle.version>8.5</checkstyle.version>
<checkstyle.version>8.17</checkstyle.version>
</properties>

<dependencies>
@@ -297,7 +297,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<version>3.0.0</version>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
@@ -197,10 +197,7 @@
<!--<property name="forbiddenSummaryFragments" value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>-->
<!--</module>-->
<module name="JavadocParagraph"/>
<!--<module name="AtclauseOrder">-->
<!--<property name="tagOrder" value="@param, @return, @throws, @deprecated"/>-->
<!--<property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>-->
<!--</module>-->
<module name="AtclauseOrder"/>
<!-- This requires to place @Override for all the overridden methods so it does not complain on missing javadocs
<module name="JavadocMethod">
<property name="scope" value="public"/>
@@ -220,15 +220,15 @@
/**
* Connection configuration regarding automatic per-query savepoints.
*
* @see PGProperty#AUTOSAVE
* @return connection configuration regarding automatic per-query savepoints
* @see PGProperty#AUTOSAVE
*/
AutoSave getAutosave();

/**
* Configures if connection should use automatic savepoints.
* @see PGProperty#AUTOSAVE
* @param autoSave connection configuration regarding automatic per-query savepoints
* @see PGProperty#AUTOSAVE
*/
void setAutosave(AutoSave autoSave);

@@ -798,10 +798,9 @@ public static boolean isOperatorChar(char c) {
* PostgreSQL 9.4 allows column names like _, ‿, ⁀, ⁔, ︳, ︴, ﹍, ﹎, ﹏, _, so
* it is assumed isJavaIdentifierPart is good enough for PostgreSQL.
*
* @see <a href="https://www.postgresql.org/docs/9.6/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS">Identifiers and Key Words</a>
*
* @param c the character to check
* @return true if valid as first character of an identifier; false if not
* @see <a href="https://www.postgresql.org/docs/9.6/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS">Identifiers and Key Words</a>
*/
public static boolean isIdentifierStartChar(char c) {
/*
@@ -1281,48 +1281,48 @@ public void initializeFrom(BaseDataSource source) throws IOException, ClassNotFo
}

/**
* @see PGProperty#PREFER_QUERY_MODE
* @return preferred query execution mode
* @see PGProperty#PREFER_QUERY_MODE
*/
public PreferQueryMode getPreferQueryMode() {
return PreferQueryMode.of(PGProperty.PREFER_QUERY_MODE.get(properties));
}

/**
* @see PGProperty#PREFER_QUERY_MODE
* @param preferQueryMode extended, simple, extendedForPrepared, or extendedCacheEverything
* @see PGProperty#PREFER_QUERY_MODE
*/
public void setPreferQueryMode(PreferQueryMode preferQueryMode) {
PGProperty.PREFER_QUERY_MODE.set(properties, preferQueryMode.value());
}

/**
* @see PGProperty#AUTOSAVE
* @return connection configuration regarding automatic per-query savepoints
* @see PGProperty#AUTOSAVE
*/
public AutoSave getAutosave() {
return AutoSave.of(PGProperty.AUTOSAVE.get(properties));
}

/**
* @see PGProperty#AUTOSAVE
* @param autoSave connection configuration regarding automatic per-query savepoints
* @see PGProperty#AUTOSAVE
*/
public void setAutosave(AutoSave autoSave) {
PGProperty.AUTOSAVE.set(properties, autoSave.value());
}

/**
* @see PGProperty#REWRITE_BATCHED_INSERTS
* @return boolean indicating property is enabled or not.
* @see PGProperty#REWRITE_BATCHED_INSERTS
*/
public boolean getReWriteBatchedInserts() {
return PGProperty.REWRITE_BATCHED_INSERTS.getBoolean(properties);
}

/**
* @see PGProperty#REWRITE_BATCHED_INSERTS
* @param reWrite boolean value to set the property in the properties collection
* @see PGProperty#REWRITE_BATCHED_INSERTS
*/
public void setReWriteBatchedInserts(boolean reWrite) {
PGProperty.REWRITE_BATCHED_INSERTS.set(properties, reWrite);
@@ -118,8 +118,8 @@
* method explicit, because {@link PGReplicationStream} send status to backend periodical by
* configured interval via {@link LogicalReplicationOptions#getStatusInterval}
*
* @see LogicalReplicationOptions#getStatusInterval()
* @throws SQLException when some internal exception occurs during read from stream
* @see LogicalReplicationOptions#getStatusInterval()
*/
void forceUpdateStatus() throws SQLException;

@@ -596,9 +596,9 @@ public void testBatchWithAlternatingAndUnknownTypes6() throws SQLException {
* BatchExecuteTest.testBatchWithAlternatingAndUnknownTypes4
* BatchExecuteTest.testBatchWithAlternatingAndUnknownTypes5
* BatchExecuteTest.testBatchWithAlternatingAndUnknownTypes6</p>
* @throws SQLException in case of failure
* @param numPreliminaryInserts number of preliminary inserts to make so the statement gets
* prepared
* @throws SQLException in case of failure
*/
public void testBatchWithAlternatingAndUnknownTypesN(int numPreliminaryInserts)
throws SQLException {

0 comments on commit 7ae1e83

Please sign in to comment.
You can’t perform that action at this time.