Permalink
Browse files

refactor: clean up PgDatabaseMetaData (#692)

PgDatabaseMetaData contains the methods rowChangesAreDetected,
rowChangesAreVisible and providesQueryObjectGenerator. They are not
documented, have no tests, always returns false and are not specified
in DatabaseMetaData.

This commit removes them.
  • Loading branch information...
marschall authored and vlsi committed Nov 25, 2016
1 parent f75572b commit d32b077e20b2afae9c4c80f704f7c8a26a8b8e11
Showing with 0 additions and 14 deletions.
  1. +0 −14 pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java
@@ -2463,16 +2463,6 @@ public Connection getConnection() throws SQLException {
return connection;
}
/* I don't find these in the spec!?! */
public boolean rowChangesAreDetected(int type) throws SQLException {
return false;
}
public boolean rowChangesAreVisible(int type) throws SQLException {
return false;
}
protected Statement createMetaDataStatement() throws SQLException {
return connection.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE,
ResultSet.CONCUR_READ_ONLY);
@@ -2524,10 +2514,6 @@ public ResultSet getClientInfoProperties() throws SQLException {
return ((BaseStatement) createMetaDataStatement()).createDriverResultSet(f, v);
}
public boolean providesQueryObjectGenerator() throws SQLException {
return false;
}
public boolean isWrapperFor(Class<?> iface) throws SQLException {
return iface.isAssignableFrom(getClass());
}

0 comments on commit d32b077

Please sign in to comment.