Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
LocalDateTimehandling of BC dates (#1388)
The assertion in `SetObject310Test.testSetLocalDateTimeBc` is > // -1997-06-30T23:59:59.999999 -> 1997-06-30 23:59:59.999999 BC This is incorrect. It is actually `-1996 == 1997 BC` because there is no year zero in AD/BC. I used a `DateTimeFormatter` in the test to prove my case. This “fix” for this method is to fix `TimeStampUtils.appendDate` and stop using the proleptic year (aka `YEAR`) and start using the year of the era (aka `YEAR_OF_ERA`).
- Loading branch information
Showing with 26 additions and 3 deletions.