Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace toArray(new T[size]) with toArray(new T[0]) #1395

Closed
hc-codersatlas opened this issue Jan 23, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@hc-codersatlas
Copy link
Contributor

commented Jan 23, 2019

Hi, noticed many occurrences of toArray that could be made faster with a find and replace.

Performance: replace toArray(new T[size]) with toArray(new T[0])

https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion (also contains benchmarks).

Could provide some simple performance improvements thanks!

davecramer added a commit that referenced this issue Jan 29, 2019

Optimize toArray (#1395) (#1396)
* Optimize toArray (#1395)

replace toArray(new T[size]) with toArray(new T[0]) for better performance

* Optimize toArray (#1395)

replace toArray(new T[size]) with toArray(new T[0]) for better performance

https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion (also contains benchmarks).
@jorsol

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

Merged, please close.

@davecramer davecramer closed this Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.