Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace toArray(new T[size]) with toArray(new T[0]) #1395

Closed
re-thc opened this issue Jan 23, 2019 · 1 comment
Closed

Replace toArray(new T[size]) with toArray(new T[0]) #1395

re-thc opened this issue Jan 23, 2019 · 1 comment

Comments

@re-thc
Copy link
Contributor

@re-thc re-thc commented Jan 23, 2019

Hi, noticed many occurrences of toArray that could be made faster with a find and replace.

Performance: replace toArray(new T[size]) with toArray(new T[0])

https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion (also contains benchmarks).

Could provide some simple performance improvements thanks!

davecramer added a commit that referenced this issue Jan 29, 2019
* Optimize toArray (#1395)

replace toArray(new T[size]) with toArray(new T[0]) for better performance

* Optimize toArray (#1395)

replace toArray(new T[size]) with toArray(new T[0]) for better performance

https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion (also contains benchmarks).
@jorsol
Copy link
Member

@jorsol jorsol commented Jan 29, 2019

Merged, please close.

@davecramer davecramer closed this Jan 29, 2019
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
* Optimize toArray (pgjdbc#1395)

replace toArray(new T[size]) with toArray(new T[0]) for better performance

* Optimize toArray (pgjdbc#1395)

replace toArray(new T[size]) with toArray(new T[0]) for better performance

https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion (also contains benchmarks).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants