Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be good to have a karaf feature for the postgresql JDBC driver #1552

Closed
steinarb opened this issue Aug 29, 2019 · 3 comments

Comments

@steinarb
Copy link
Contributor

commented Aug 29, 2019

Apache karaf has a concept called "karaf features" that is used to provide runtime dependencies for OSGi applications.

I have manually created a postgresql jdbc driver karaf feature, because that gives smoother loading and unloading when I have more than one webapp using the postgresql jdbc driver.

It would be nice ifthe postgresql driver provided its own karaf feature. It's possible to piggyback the feature creation on the maven build process, using the karaf-maven-plugin and attach the feature artifacts to the deployed maven resources.

If there is interest in this, I can create a pull request.

@davecramer

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

@steinarb I don't personally have much knowledge about OSGI. If you think this is a feature you find useful then by all means create a PR. It would be nice if there was a way to test this.

@steinarb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@davecramer Great! I will work on a PR and try to think of a way to test the feature (it would be possible to create a pax exam integration test that would verify that the feature works and loads the JDBC driver and provides a DataSourceFactory, but that may be overkill...?)

@steinarb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

I've created a pull request, but it didn't appear here: #1554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.