Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency changes after Gradle migration #1795

Closed
Sanne opened this issue Jun 8, 2020 · 3 comments · Fixed by #1797
Closed

Dependency changes after Gradle migration #1795

Sanne opened this issue Jun 8, 2020 · 3 comments · Fixed by #1797

Comments

@Sanne
Copy link

Sanne commented Jun 8, 2020

Describe the issue
After migrating to driver version 4.2.13 we had to add some explicit exclusions to the dependency tree:

https://github.com/quarkusio/quarkus/blob/d3c9f7a1612212ccf7327b3681321296c0c87afe/extensions/jdbc/jdbc-postgresql/runtime/pom.xml#L21-L41

Driver Version?
4.2.13

Java Version?
N/A

OS Version?
N/A

PostgreSQL Version?
N/A

To Reproduce
Create an empty, trivial Maven project which depends on org.postgresql:postgresql and checkout the dependency tree.

For version 4.2.13 you'll see additional dependencies listed, which aren't really required as most applications will work just fine without them.

One can see those same dependencies are marked as optional explicitly in previous version 4.2.12.

Alternatively, check out my commit on Quarkus quarkusio/quarkus@d3c9f7a#diff-429d348cc374e85899538ee6abe11159R24-R40 - one can see the need for the exclusions.

Expectations
For those dependencies to be listed as optional (as in previous versions), so to not need to specify exclusions.

Thanks!

@davecramer
Copy link
Member

davecramer commented Jun 9, 2020

@Sanne thx for the report. Likely looking at 42.3.x before a fix.

@Sanne
Copy link
Author

Sanne commented Jun 9, 2020

thanks @davecramer ! No rush, we can easily work around it.

vlsi added a commit to vlsi/pgjdbc that referenced this issue Jun 9, 2020
That results in optional=true in the published pom.xml.

We do not publish Gradle Metadata yet as it is not trivial
to publish shadowed jar under default coordinate and generate
metadata for it.

closes pgjdbc#1795
vlsi added a commit to vlsi/pgjdbc that referenced this issue Jun 10, 2020
That results in optional=true in the published pom.xml.

We do not publish Gradle Metadata yet as it is not trivial
to publish shadowed jar under default coordinate and generate
metadata for it.

closes pgjdbc#1795
vlsi added a commit that referenced this issue Jun 10, 2020
That results in optional=true in the published pom.xml.

We do not publish Gradle Metadata yet as it is not trivial
to publish shadowed jar under default coordinate and generate
metadata for it.

closes #1795
@Sanne
Copy link
Author

Sanne commented Jun 10, 2020

Many thanks for the quick fix @vlsi !

cc/ @wilkinsona

davecramer pushed a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
That results in optional=true in the published pom.xml.

We do not publish Gradle Metadata yet as it is not trivial
to publish shadowed jar under default coordinate and generate
metadata for it.

closes pgjdbc#1795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants