New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for identity, fix isAutoincrement in postgresql 10 fixes #130 #1004

Merged
merged 3 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@davecramer
Member

davecramer commented Oct 31, 2017

No description provided.

@davecramer

This comment has been minimized.

Member

davecramer commented Oct 31, 2017

clearly needs more work

+ "FROM pg_catalog.pg_class c "
+ "a.attnotnull OR (t.typtype = 'd' AND t.typnotnull), ");
if ( connection.haveMinimumServerVersion(10)) {

This comment has been minimized.

@vlsi

vlsi Oct 31, 2017

Member

I guess it should use ServerVersion or something around that

This comment has been minimized.

@davecramer

davecramer Oct 31, 2017

Member

yes, done

@codecov-io

This comment has been minimized.

codecov-io commented Oct 31, 2017

Codecov Report

Merging #1004 into master will increase coverage by 0.03%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master    #1004      +/-   ##
============================================
+ Coverage     65.91%   65.94%   +0.03%     
- Complexity     3579     3583       +4     
============================================
  Files           167      167              
  Lines         15316    15320       +4     
  Branches       2480     2481       +1     
============================================
+ Hits          10095    10103       +8     
+ Misses         4044     4042       -2     
+ Partials       1177     1175       -2
@@ -248,6 +258,17 @@ public void testClosedResultSet() throws Exception {
assertEquals("rsmd1", rsmd.getColumnTypeName(1));
}
@Test
public void testIdentityColumn() throws Exception {
if (TestUtil.haveMinimumServerVersion(conn, ServerVersion.v10)) {

This comment has been minimized.

@vlsi

vlsi Oct 31, 2017

Member

There's "assume..." for that.

@davecramer

This comment has been minimized.

Member

davecramer commented Oct 31, 2017

thx, updated

@davecramer davecramer merged commit 2f6633b into pgjdbc:master Nov 7, 2017

2 checks passed

codecov/project 65.94% (+0.03%) compared to 9813c68
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davecramer davecramer deleted the davecramer:fixidentity branch Nov 7, 2017

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

add test for identity, fix isAutoincrement in postgresql 10 fixes pgj…
…dbc#130 (pgjdbc#1004)

* add test for identity, fix isAutoincrement in postgresql 10 fixes pgjdbc#130

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

add test for identity, fix isAutoincrement in postgresql 10 fixes pgj…
…dbc#130 (pgjdbc#1004)

* add test for identity, fix isAutoincrement in postgresql 10 fixes pgjdbc#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment