Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always return Short[] for java.sql.Array.getArray() on smallint[] #1017

Merged
merged 1 commit into from Nov 15, 2017

Conversation

@thachhoang
Copy link
Contributor

@thachhoang thachhoang commented Nov 14, 2017

Fix #420.

Without the changes to PgArray, the new test fails for BinaryMode.REGULAR and passes for BinaryMode.FORCE.

@davecramer
Copy link
Member

@davecramer davecramer commented Nov 15, 2017

@thachhoang thanks for this. LGTM anyone else care to comment before I merge this ?

@vlsi vlsi added this to the 42.1.5 milestone Nov 15, 2017
@vlsi vlsi merged commit 279fb43 into pgjdbc:master Nov 15, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi
Copy link
Member

@vlsi vlsi commented Nov 15, 2017

👍

@thachhoang thachhoang deleted the thachhoang:420-smallint-array branch Nov 15, 2017
@vlsi vlsi modified the milestones: 42.1.5, 42.2.0 Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants