Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify methods in ConnectionFactoryImpl #1028

Merged
merged 3 commits into from Dec 17, 2017

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Nov 30, 2017

simplify some methods in ConnectionFactoryImpl

simplify some methods in ConnectionFactoryImpl

SocketFactory socketFactory = SocketFactoryFactory.getSocketFactory(info);

HostChooser hostChooser =
HostChooserFactory.createHostChooser(hostSpecs, targetServerType, info);
HostChooser hostChooser = HostChooserFactory.createHostChooser(hostSpecs, targetServerType, info);

This comment has been minimized.

@vlsi

vlsi Nov 30, 2017
Member

@AlexElin , these changes would conflict with #844

Would you possibly like to review #844 as well?

This comment has been minimized.

@AlexElin

AlexElin Dec 5, 2017
Author Contributor

@vlsi I reverted conflicting changes

revert getTargetServerType()
org.postgresql.gss.MakeGSS.authenticate(pgStream, host, user, password,
PGProperty.JAAS_APPLICATION_NAME.get(info),
PGProperty.KERBEROS_SERVER_NAME.get(info), usespnego);
if (useSSPI) {

This comment has been minimized.

@vlsi

vlsi Dec 16, 2017
Member

This change looks suspicious, and I would refrain from doing that considering SSPI is not covered by the CI tests.

Would you please revert the change?

This comment has been minimized.

@AlexElin

AlexElin Dec 17, 2017
Author Contributor

reverted

revert SSPI-related changes
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 17, 2017

Codecov Report

Merging #1028 into master will increase coverage by 0.02%.
The diff coverage is 80.76%.

@@             Coverage Diff              @@
##             master    #1028      +/-   ##
============================================
+ Coverage     66.35%   66.38%   +0.02%     
- Complexity     3607     3609       +2     
============================================
  Files           168      168              
  Lines         15355    15365      +10     
  Branches       2483     2495      +12     
============================================
+ Hits          10189    10200      +11     
+ Misses         3985     3981       -4     
- Partials       1181     1184       +3
@vlsi
vlsi approved these changes Dec 17, 2017
@vlsi vlsi added this to the 42.2.0 milestone Dec 17, 2017
@vlsi vlsi merged commit ed27c5b into pgjdbc:master Dec 17, 2017
2 checks passed
2 checks passed
codecov/project 66.38% (+0.02%) compared to 405f14e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants