New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage to java 7 #1030

Merged
merged 1 commit into from Dec 16, 2017

Conversation

Projects
None yet
3 participants
@jorsol
Contributor

jorsol commented Dec 5, 2017

Add coverage for Java 7 builds, make sync with after_n_builds.

@@ -130,6 +130,7 @@ matrix:
- PG_VERSION=9.2
- ZULU_JDK=7
- MCENTRAL=Y
- COVERAGE=Y

This comment has been minimized.

@vlsi

vlsi Dec 5, 2017

Member

There are 10 COVERAGE=Y lines and after_n_builds is 8.
How does that play together?

PS. Could you add a test that compares after_n_builds vs number of COVERAGE jobs?

This comment has been minimized.

@jorsol

jorsol Dec 5, 2017

Contributor

mmm... I must forgot update after_n_builds

PS. Could you add a test that compares after_n_builds vs number of COVERAGE jobs?

Something like another job?

This comment has been minimized.

This comment has been minimized.

@jorsol

jorsol Dec 5, 2017

Contributor

I actually added a test to break the build before anything, this will work like a fail-fast test since is useless to test to the end and break there.

@codecov-io

This comment has been minimized.

codecov-io commented Dec 5, 2017

Codecov Report

Merging #1030 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1030      +/-   ##
============================================
- Coverage     66.35%   65.75%   -0.61%     
+ Complexity     3607     3564      -43     
============================================
  Files           168      168              
  Lines         15355    15365      +10     
  Branches       2483     2495      +12     
============================================
- Hits          10189    10103      -86     
- Misses         3985     4053      +68     
- Partials       1181     1209      +28
test: add coverage to java 7
This PR adds coverage to Java 7 build and ignore the coverage for the failing test of
extendedCacheEverything.

Add a check for break the build if the after_n_builds don't match COVERAGE jobs.

@jorsol jorsol force-pushed the jorsol:coverage-java7 branch from 81978bd to 0729568 Dec 5, 2017

@vlsi vlsi added this to the 42.2.0 milestone Dec 16, 2017

@vlsi vlsi merged commit b629934 into pgjdbc:master Dec 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

chore: collect coverage for Java 7 (pgjdbc#1030)
This PR adds coverage to Java 7 build and ignore the coverage for the failing test of
extendedCacheEverything.

Add a check for break the build if the after_n_builds don't match COVERAGE jobs.

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

chore: collect coverage for Java 7 (pgjdbc#1030)
This PR adds coverage to Java 7 build and ignore the coverage for the failing test of
extendedCacheEverything.

Add a check for break the build if the after_n_builds don't match COVERAGE jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment