Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace some usages of initCause #1037

Merged
merged 1 commit into from Jan 12, 2018

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Dec 18, 2017

replace some usages of initCause with appropriate constructor

replace some usages of initCause with appropriate constructor
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 18, 2017

Codecov Report

Merging #1037 into master will increase coverage by <.01%.
The diff coverage is 37.5%.

@@             Coverage Diff              @@
##             master    #1037      +/-   ##
============================================
+ Coverage     66.39%   66.39%   +<.01%     
+ Complexity     3609     3607       -2     
============================================
  Files           168      168              
  Lines         15365    15355      -10     
  Branches       2495     2494       -1     
============================================
- Hits          10201    10195       -6     
+ Misses         3979     3974       -5     
- Partials       1185     1186       +1
@davecramer davecramer merged commit 0c29823 into pgjdbc:master Jan 12, 2018
2 checks passed
2 checks passed
codecov/project 66.39% (+<.01%) compared to ed27c5b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi
Copy link
Member

@vlsi vlsi commented Jan 12, 2018

@davecramer , frankly speaking, I do not like how refactor: replace some usages of initCause does change 40 unrelated lines.

On top of that, this change introduces little help, yet it introduces merge conflict with #935 that has been there for ages.

I'm inclined to revert #1037

@davecramer
Copy link
Member

@davecramer davecramer commented Jan 12, 2018

fair enough, but lets get #935 in then

@vlsi
Copy link
Member

@vlsi vlsi commented Jan 12, 2018

lets get #935 in then

Fair, but let's do that after 42.2.0?

@davecramer
Copy link
Member

@davecramer davecramer commented Jan 12, 2018

sure..

davecramer added a commit that referenced this pull request Jan 12, 2018
This reverts commit 0c29823.
davecramer added a commit that referenced this pull request Jan 12, 2018
This reverts commit 0c29823.
@AlexElin AlexElin deleted the AlexElin:replace_initCause branch Mar 11, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
replace some usages of initCause with appropriate constructor
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
replace some usages of initCause with appropriate constructor
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants