first pass at release notes and some fixes to previous notes #1041
Conversation
I think we are going to skip 42.1.5 and just release as 42.2.0 |
@@ -3,7 +3,7 @@ Notable changes since version 42.0.0, read the complete [History of Changes](htt | |||
|
|||
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). | |||
|
|||
## [Unreleased] | |||
## [Unreleased]nn## [42.1.5] (2017-12-21) |
jorsol
Dec 21, 2017
Member
Not sure what fails here, this should be 2 new lines, not 2 "n".
Not sure what fails here, this should be 2 new lines, not 2 "n".
Fair enough |
And there are some missing items in the CHANGELOG. |
@jorsol could you enumerate what is missing ? |
Yes, let me check on that. |
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
===========================================
+ Coverage 66.66% 67.2% +0.53%
- Complexity 3659 3660 +1
===========================================
Files 170 170
Lines 15788 15617 -171
Branches 2582 2520 -62
===========================================
- Hits 10525 10495 -30
+ Misses 4061 3936 -125
+ Partials 1202 1186 -16 |
@davecramer, I have this items:
|
I ran ./release_notes.sh How did you get that output ? |
No, the CHANGELOG has to be feed manually, the release_notes.sh prepares the post for the website. Maybe we should ask that PRs include info for the CHANGELOG, look for instance this PR: https://github.com/pgjdbc/pgjdbc/pull/935/files |
I suggest to refine the notes, release 42.2.0, and resolve the open issues later. |
Agreed, we've waited too long
Dave Cramer
…On 12 January 2018 at 02:26, Vladimir Sitnikov ***@***.***> wrote:
@davecramer <https://github.com/davecramer> ,
I suggest to refine the notes, release 42.2.0, and resolve the open issues
later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1041 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAYz9qzFt7ppn2kzLmJ7iwXJNMrUqxjCks5tJwlCgaJpZM4RKD4J>
.
|
- Parse CommandComplete message using a regular expresion, allows complete catch of server returned commands for INSERT, UPDATE, DELETE, SELECT, FETCH, MOVE, COPY and future commands. [PR 962](https://github.com/pgjdbc/pgjdbc/pull/962) | ||
- Use 'time with timezone' and 'timestamp with timezone' as is and ignore the user provided Calendars, 'time' and 'timestamp' work as earlier except "00:00:00" now maps to 1970-01-01 and "24:00:00" uses the system provided Calendar ignoring the user-provided one [PR 1053](https://github.com/pgjdbc/pgjdbc/pull/1053) | ||
- Change behaviour of multihost connection. The new behaviour is to try all slaves first before trying the master [PR 844](https://github.com/pgjdbc/pgjdbc/pull/844). |
vlsi
Jan 14, 2018
Member
s/slaves/secondaries/
?
s/slaves/secondaries/
?
Good point apparently we are no longer using the word slaves
Dave Cramer
…On 14 January 2018 at 16:14, Vladimir Sitnikov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CHANGELOG.md
<#1041 (comment)>:
> - Parse CommandComplete message using a regular expresion, allows complete catch of server returned commands for INSERT, UPDATE, DELETE, SELECT, FETCH, MOVE, COPY and future commands. [PR 962](#962)
+- Use 'time with timezone' and 'timestamp with timezone' as is and ignore the user provided Calendars, 'time' and 'timestamp' work as earlier except "00:00:00" now maps to 1970-01-01 and "24:00:00" uses the system provided Calendar ignoring the user-provided one [PR 1053](#1053)
+- Change behaviour of multihost connection. The new behaviour is to try all slaves first before trying the master [PR 844](#844).
s/slaves/secondaries/ ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1041 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYz9rJ3SXAzCb1SHsfAGSBo_8_nIgWgks5tKm4_gaJpZM4RKD4J>
.
|
**Notable changes** | ||
|
||
|
||
## [42.2.0] (2017-12-21) |
vlsi
Jan 14, 2018
Member
Please remove this line from _posts/2018-01-14-42.2.0-release.md
. Version title is generated automatically by Jekyll (see https://github.com/pgjdbc/pgjdbc/blame/5d585aac7e4f916d4b54dccd11c778143a1f7725/docs/documentation/changelog.md#L80 )
Please remove this line from _posts/2018-01-14-42.2.0-release.md
. Version title is generated automatically by Jekyll (see https://github.com/pgjdbc/pgjdbc/blame/5d585aac7e4f916d4b54dccd11c778143a1f7725/docs/documentation/changelog.md#L80 )
@@ -4,12 +4,32 @@ Notable changes since version 42.0.0, read the complete [History of Changes](htt | |||
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). | |||
|
|||
## [Unreleased] | |||
|
|||
## [42.2.0] (2017-12-21) |
jorsol
Jan 14, 2018
Member
Date: 2018-01-14
Date: 2018-01-14
thx for the review
Dave Cramer
…On 14 January 2018 at 16:25, Jorge Solorzano ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CHANGELOG.md
<#1041 (comment)>:
> @@ -4,12 +4,32 @@ Notable changes since version 42.0.0, read the complete [History of Changes](htt
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
## [Unreleased]
+
+## [42.2.0] (2017-12-21)
Date: 2018-01-14
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1041 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYz9vym8qigjN06BFaOo1K1xJ6uvg3Nks5tKnDEgaJpZM4RKD4J>
.
|
a8260f5
into
pgjdbc:master
…1041) * fix Changelog, and move to version 42.2.0
…1041) * fix Changelog, and move to version 42.2.0
No description provided.