Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at release notes and some fixes to previous notes #1041

Merged
merged 9 commits into from Jan 16, 2018

Conversation

@davecramer
Copy link
Member

@davecramer davecramer commented Dec 21, 2017

No description provided.

@vlsi
Copy link
Member

@vlsi vlsi commented Dec 21, 2017

I think we are going to skip 42.1.5 and just release as 42.2.0

@@ -3,7 +3,7 @@ Notable changes since version 42.0.0, read the complete [History of Changes](htt

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## [Unreleased]
## [Unreleased]nn## [42.1.5] (2017-12-21)

This comment has been minimized.

@jorsol

jorsol Dec 21, 2017
Member

Not sure what fails here, this should be 2 new lines, not 2 "n".

@davecramer
Copy link
Member Author

@davecramer davecramer commented Dec 21, 2017

Fair enough

@jorsol
Copy link
Member

@jorsol jorsol commented Dec 21, 2017

And there are some missing items in the CHANGELOG.

@davecramer
Copy link
Member Author

@davecramer davecramer commented Dec 21, 2017

@jorsol could you enumerate what is missing ?

@jorsol
Copy link
Member

@jorsol jorsol commented Dec 21, 2017

Yes, let me check on that.

@codecov-io
Copy link

@codecov-io codecov-io commented Dec 21, 2017

Codecov Report

Merging #1041 into master will increase coverage by 0.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #1041      +/-   ##
===========================================
+ Coverage     66.66%   67.2%   +0.53%     
- Complexity     3659    3660       +1     
===========================================
  Files           170     170              
  Lines         15788   15617     -171     
  Branches       2582    2520      -62     
===========================================
- Hits          10525   10495      -30     
+ Misses         4061    3936     -125     
+ Partials       1202    1186      -16
@jorsol
Copy link
Member

@jorsol jorsol commented Dec 21, 2017

@davecramer, I have this items:

## [Unreleased]
### Added
- Support SCRAM-SHA-256 for PostgreSQL 10 in the JDBC 4.2 version (Java 8+) using the Ongres SCRAM library. [PR 842](https://github.com/pgjdbc/pgjdbc/pull/842)
- Make SELECT INTO and CREATE TABLE AS return row counts to the client in their command tags. [Issue 958](https://github.com/pgjdbc/pgjdbc/issues/958) [PR 962](https://github.com/pgjdbc/pgjdbc/pull/962)
- Support Subject Alternative Names for SSL connections. [PR 952](https://github.com/pgjdbc/pgjdbc/pull/952)
- Support isAutoIncrement metadata for PostgreSQL 10 IDENTITY column. [PR 1004](https://github.com/pgjdbc/pgjdbc/pull/1004)
- Support for primitive arrays [PR#887](https://github.com/pgjdbc/pgjdbc/pull/887) [3e0491a](https://github.com/pgjdbc/pgjdbc/commit/3e0491ac3833800721b98e7437635cf6ab338162)
- Implement support for get/setNetworkTimeout() in connections. [PR 849](https://github.com/pgjdbc/pgjdbc/pull/849)

### Changed
- Improve behavior of ResultSet.getObject(int, Class). [PR 932](https://github.com/pgjdbc/pgjdbc/pull/932)
- Parse CommandComplete message using a regular expresion, allows complete catch of server returned commands for INSERT, UPDATE, DELETE, SELECT, FETCH, MOVE, COPY and future commands. [PR 962](https://github.com/pgjdbc/pgjdbc/pull/962)

### Fixed
- Make warnings available as soon as they are received from the server. This is useful for long running queries, where it can be beneficial to know about a warning before the query completes. [PR 857](https://github.com/pgjdbc/pgjdbc/pull/857)
- Use 00:00:00 and 24:00:00 for LocalTime.MIN/MAX. [PR 992](https://github.com/pgjdbc/pgjdbc/pull/992)
- Now the DatabaseMetaData.getFunctions() implementation complies with the JDBC docs. [PR 918](https://github.com/pgjdbc/pgjdbc/pull/918)

### Removed
- Drop support for the (insecure) crypt authentication method. [PR 1026](https://github.com/pgjdbc/pgjdbc/pull/1026)

### Deprecated
- Reintroduce Driver.getVersion for backward compatibility reasons, mark it as deprecated as application should not rely on it (regression since 42.0.0) [50d5dd3e](https://github.com/pgjdbc/pgjdbc/commit/50d5dd3e708a92602e04d6b4aa0822ad3f110a78)

@davecramer
Copy link
Member Author

@davecramer davecramer commented Dec 21, 2017

@jorsol

I ran ./release_notes.sh How did you get that output ?

@jorsol
Copy link
Member

@jorsol jorsol commented Dec 21, 2017

No, the CHANGELOG has to be feed manually, the release_notes.sh prepares the post for the website.

Maybe we should ask that PRs include info for the CHANGELOG, look for instance this PR: https://github.com/pgjdbc/pgjdbc/pull/935/files

@vlsi
Copy link
Member

@vlsi vlsi commented Jan 12, 2018

@davecramer ,

I suggest to refine the notes, release 42.2.0, and resolve the open issues later.

@davecramer
Copy link
Member Author

@davecramer davecramer commented Jan 12, 2018

davecramer added 2 commits Jan 12, 2018
- Parse CommandComplete message using a regular expresion, allows complete catch of server returned commands for INSERT, UPDATE, DELETE, SELECT, FETCH, MOVE, COPY and future commands. [PR 962](https://github.com/pgjdbc/pgjdbc/pull/962)
- Use 'time with timezone' and 'timestamp with timezone' as is and ignore the user provided Calendars, 'time' and 'timestamp' work as earlier except "00:00:00" now maps to 1970-01-01 and "24:00:00" uses the system provided Calendar ignoring the user-provided one [PR 1053](https://github.com/pgjdbc/pgjdbc/pull/1053)
- Change behaviour of multihost connection. The new behaviour is to try all slaves first before trying the master [PR 844](https://github.com/pgjdbc/pgjdbc/pull/844).

This comment has been minimized.

@vlsi

vlsi Jan 14, 2018
Member

s/slaves/secondaries/ ?

@davecramer
Copy link
Member Author

@davecramer davecramer commented Jan 14, 2018

**Notable changes**


## [42.2.0] (2017-12-21)

This comment has been minimized.

@vlsi

vlsi Jan 14, 2018
Member

Please remove this line from _posts/2018-01-14-42.2.0-release.md. Version title is generated automatically by Jekyll (see https://github.com/pgjdbc/pgjdbc/blame/5d585aac7e4f916d4b54dccd11c778143a1f7725/docs/documentation/changelog.md#L80 )

@@ -4,12 +4,32 @@ Notable changes since version 42.0.0, read the complete [History of Changes](htt
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## [Unreleased]

## [42.2.0] (2017-12-21)

This comment has been minimized.

@jorsol

jorsol Jan 14, 2018
Member

Date: 2018-01-14

@davecramer
Copy link
Member Author

@davecramer davecramer commented Jan 14, 2018

@davecramer davecramer merged commit a8260f5 into pgjdbc:master Jan 16, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants