Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprefactor: simplify PgConnection.java #1047
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 27, 2017
Codecov Report
@@ Coverage Diff @@
## master #1047 +/- ##
============================================
- Coverage 66.83% 66.82% -0.01%
Complexity 3637 3637
============================================
Files 169 169
Lines 15593 15589 -4
Branches 2529 2528 -1
============================================
- Hits 10422 10418 -4
Misses 3977 3977
Partials 1194 1194 |
| private Set<Integer> getBinaryOids(Properties info) throws PSQLException { | ||
| boolean binaryTransfer = PGProperty.BINARY_TRANSFER.getBoolean(info); | ||
| // Formats that currently have binary protocol support | ||
| Set<Integer> binaryOids = new HashSet<Integer>(); |
This comment has been minimized.
This comment has been minimized.
bokken
Dec 28, 2017
Member
consider initializing this to a reasonable size to limit (or eliminate) the need to reallocate the backing array. the default starting size of 16 currently guarantees (at least) 1 reallocation each time this method is called.
This comment has been minimized.
This comment has been minimized.
AlexElin
Jan 14, 2018
Contributor
made changes. Set initial capacity to 32 (20 values if binaryTransfer enabled + some values from BINARY_TRANSFER_ENABLE)
| binaryOids.removeAll(getOidSet(PGProperty.BINARY_TRANSFER_DISABLE.get(info))); | ||
| return binaryOids; | ||
| } | ||
|
|
||
| private Set<Integer> getOidSet(String oidList) throws PSQLException { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -328,6 +292,39 @@ public TimeZone get() { | |||
| replicationConnection = PGProperty.REPLICATION.get(info) != null; | |||
| } | |||
|
|
|||
| private Set<Integer> getBinaryOids(Properties info) throws PSQLException { | |||
This comment has been minimized.
This comment has been minimized.
bokken
Dec 28, 2017
Member
if getOidSet is changed to static, consider changing this method to static.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vlsi
force-pushed the
pgjdbc:master
branch
from
4a6d1d1
to
5819f31
Jan 17, 2018
vlsi
added this to the 42.2.3 milestone
Jun 30, 2018
vlsi
merged commit ba360f7
into
pgjdbc:master
Jun 30, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
added a commit
to bolcom/pgjdbc
that referenced
this pull request
Jul 13, 2018
added a commit
to bolcom/pgjdbc
that referenced
this pull request
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AlexElin commentedDec 27, 2017
simplify constructor in PgConnection