New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check if url is not for PostgreSQL #1077

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
3 participants
@AlexElin
Contributor

AlexElin commented Jan 18, 2018

java.sql.Driver's javadoc states " The driver should return "null" if it realizes it is the wrong kind of driver to connect to the given URL. This will be common, as when the JDBC driver manager is asked to connect to a given URL it passes the URL to each loaded driver in turn." (https://docs.oracle.com/javase/8/docs/api/java/sql/Driver.html#connect-java.lang.String-java.util.Properties-).

Add test for checking this behaviour.

@codecov-io

This comment has been minimized.

codecov-io commented Jan 18, 2018

Codecov Report

Merging #1077 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1077   +/-   ##
=========================================
  Coverage     67.21%   67.21%           
+ Complexity     3663     3662    -1     
=========================================
  Files           170      170           
  Lines         15621    15621           
  Branches       2522     2522           
=========================================
  Hits          10500    10500           
+ Misses         3936     3935    -1     
- Partials       1185     1186    +1

@davecramer davecramer merged commit fe463bc into pgjdbc:master Jan 19, 2018

2 checks passed

codecov/project 67.21% remains the same compared to c2664b4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AlexElin AlexElin deleted the AlexElin:driver_test branch Jan 19, 2018

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment