Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1078 #1079

Merged
Merged

Conversation

@JCzogalla
Copy link
Contributor

@JCzogalla JCzogalla commented Jan 19, 2018

Check the "socksProxyHost" system property not only for null, but also for emptiness

Check the "socksProxyHost" system property not only for null, but also for emptiness
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 19, 2018

Codecov Report

Merging #1079 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #1079      +/-   ##
============================================
- Coverage     67.21%   67.18%   -0.03%     
+ Complexity     3663     3661       -2     
============================================
  Files           170      170              
  Lines         15621    15622       +1     
  Branches       2522     2523       +1     
============================================
- Hits          10500    10496       -4     
- Misses         3936     3938       +2     
- Partials       1185     1188       +3
@davecramer davecramer merged commit 0d51370 into pgjdbc:master Jan 19, 2018
1 of 2 checks passed
1 of 2 checks passed
codecov/project 67.18% (-0.03%) compared to c2664b4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JCzogalla JCzogalla deleted the JCzogalla:fix-1078-check-for-proxy-empty-string branch Jan 19, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
* Fixes issue pgjdbc#1078
Check the "socksProxyHost" system property not only for null, but also for emptiness

* pgjdbc#1078: Added test and fixed code style issues
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
* Fixes issue pgjdbc#1078
Check the "socksProxyHost" system property not only for null, but also for emptiness

* pgjdbc#1078: Added test and fixed code style issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.