Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reWriteBatchedInserts=true causes syntax error with on conflict #1082

Merged
merged 2 commits into from Jan 23, 2018

Conversation

@vlsi
Copy link
Member

@vlsi vlsi commented Jan 20, 2018

fixes #1045

fixes #1045
@vlsi vlsi added this to the 42.2.1 milestone Jan 20, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 20, 2018

Codecov Report

Merging #1082 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1082      +/-   ##
============================================
+ Coverage      67.2%   67.22%   +0.02%     
- Complexity     3662     3665       +3     
============================================
  Files           170      170              
  Lines         15622    15626       +4     
  Branches       2523     2524       +1     
============================================
+ Hits          10498    10504       +6     
+ Misses         3937     3935       -2     
  Partials       1187     1187
@vlsi vlsi merged commit e133510 into pgjdbc:master Jan 23, 2018
2 checks passed
2 checks passed
codecov/project 67.22% (+0.02%) compared to 0d51370
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
…gjdbc#1082)

INSERT into ... VALUES(...),(...),(...) ON CONFLICT (id) ... confused parser since it considered braces after on conflict to be a part of VALUES clause.
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
…gjdbc#1082)

INSERT into ... VALUES(...),(...),(...) ON CONFLICT (id) ... confused parser since it considered braces after on conflict to be a part of VALUES clause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.