Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Travis configuration to test SSL #1095

Merged
merged 11 commits into from Mar 11, 2018
Merged

test: add Travis configuration to test SSL #1095

merged 11 commits into from Mar 11, 2018

Conversation

@davecramer
Copy link
Member

@davecramer davecramer commented Jan 27, 2018

remove v2 protocol versions of the test
remove pg8 versions of the test
Enable it to run and pass on travis

remove v2 protocol versions of the test
remove pg8 versions of the test
Enable it to run and pass on travis
postgresql: "9.6"
env:
- PG_VERSION=9.6
- SSLTEST=Y

This comment has been minimized.

@vlsi

vlsi Jan 27, 2018
Member

Does it make sense to incorporate SSLTEST into existing xa / replication / ... job just to keep Travis execution "fast"?

This comment has been minimized.

@davecramer

davecramer Jan 27, 2018
Author Member

I've had to muck with pg_hba.conf to get this to work. If we can get both to work then fine

davecramer added 2 commits Jan 27, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 28, 2018

Codecov Report

Merging #1095 into master will increase coverage by 1.4%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #1095     +/-   ##
===========================================
+ Coverage     67.24%   68.64%   +1.4%     
- Complexity     3667     3705     +38     
===========================================
  Files           170      170             
  Lines         15632    15632             
  Branches       2528     2528             
===========================================
+ Hits          10512    10731    +219     
+ Misses         3931     3682    -249     
- Partials       1189     1219     +30
davecramer and others added 4 commits Jan 27, 2018
remove v2 protocol versions of the test
remove pg8 versions of the test
Enable it to run and pass on travis
@vlsi vlsi force-pushed the davecramer:ssltest2 branch from eae0a2d to ec0e58a Jan 28, 2018
@vlsi vlsi changed the title fix the ssl tests test: add Travis configuration to test SSL Jan 28, 2018
@vlsi
Copy link
Member

@vlsi vlsi commented Jan 28, 2018

@davecramer , here's an extract from https://travis-ci.org/pgjdbc/pgjdbc/jobs/334379152

 T E S T S
-------------------------------------------------------
Configuration file /home/travis/build/pgjdbc/pgjdbc/pgjdbc/../build.local.properties does not exist. Consider adding it to specify test db host and login
Skipping SingleCertSocketFactoryTests. To enable set the property testsinglecertfactory=true in the ssltest.properties file.
Configuration file /home/travis/build/pgjdbc/pgjdbc/pgjdbc/../ssltest.local.properties does not exist. Consider adding it to specify test db host and login
Skipping ssloff9.
Configuration file /home/travis/build/pgjdbc/pgjdbc/pgjdbc/../build.local.properties does not exist. Consider adding it to specify test db host and login
Running org.postgresql.replication.ReplicationTestSuite
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.124 sec - in org.postgresql.replication.ReplicationTestSuite
Running org.postgresql.test.ssl.SingleCertValidatingFactoryTestSuite
Skipping SingleCertSocketFactoryTests. To enable set the property testsinglecertfactory=true in the ssltest.properties file.
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.postgresql.test.ssl.SingleCertValidatingFactoryTestSuite
Running org.postgresql.test.ssl.SslTestSuite
Configuration file /home/travis/build/pgjdbc/pgjdbc/pgjdbc/../ssltest.local.properties does not exist. Consider adding it to specify test db host and login
Skipping ssloff9.
Tests run: 162, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.328 sec - in org.postgresql.test.ssl.SslTestSuite

Does that mean SingleCertValidatingFactoryTestSuite is still skipped?
Is that intentional?

@vlsi
Copy link
Member

@vlsi vlsi commented Jan 28, 2018

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.postgresql.test.ssl.SingleCertValidatingFactoryTestSuite

@vlsi
Copy link
Member

@vlsi vlsi commented Mar 10, 2018

Travis logs:

Running org.postgresql.test.ssl.SingleCertValidatingFactoryTestSuite
Skipping test connectSSLWithValidationProperCertEnvVar (env variable is not defined)

The test reads

  • Note: To execute this test succesfully you need to set the value of the environment variable
  • DATASOURCE_SSL_CERT prior to running the test.

@davecramer , do you think we should merge the PR and (not) fix connectSSLWithValidationProperCertEnvVar later?

@vlsi vlsi mentioned this pull request Mar 10, 2018
@davecramer
Copy link
Member Author

@davecramer davecramer commented Mar 11, 2018

@vlsi I think we should definitely merge the PR the way it is. I will look at how to fix this test later

@vlsi vlsi added this to the 42.2.2 milestone Mar 11, 2018
@vlsi vlsi merged commit 298683b into pgjdbc:master Mar 11, 2018
2 checks passed
2 checks passed
codecov/project 68.64% (+1.4%) compared to aa676bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
remove v2 protocol versions of the test
remove pg8 versions of the test
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
remove v2 protocol versions of the test
remove pg8 versions of the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants