perf: guard logging statements

[jesperpedersen]

Add some more guards to logging statements to make it consistent with other parts of the code

[jesperpedersen]

Seems like there is something wrong with the Zulu build

[vlsi]

-1

The guards are required for multi-argument calls.
The only purpose of the guards is to avoid creating Object[] for varargs (==performance reasons).

I think adding explicit if (loggable) makes code harder to read, and I do think it is good when we can avoid extra if checks

[vlsi]

This is log(Level level, String msg, Object param1), and it does not require guards

[davecramer]

Ya, that is what I thought as well

…

-1 from me as well Dave Cramer

On 13 February 2018 at 10:28, Vladimir Sitnikov ***@***.***> wrote: ***@***.**** requested changes on this pull request. -1 The guards are required for multi-argument calls. The only purpose of the guards is to avoid creating Object[] for varargs (==performance reasons). I think adding explicit if (loggable) makes code harder to read, and I do think it is good when we can avoid extra if checks ------------------------------ In pgjdbc/src/main/java/org/postgresql/core/Encoding.java <#1112 (comment)>: > @@ -148,7 +148,9 @@ public static Encoding getDatabaseEncoding(String databaseEncoding) { String[] candidates = encodings.get(databaseEncoding); if (candidates != null) { for (String candidate : candidates) { - LOGGER.log(Level.FINEST, "Search encoding candidate {0}", candidate); + if (LOGGER.isLoggable(Level.FINEST)) { + LOGGER.log(Level.FINEST, "Search encoding candidate {0}", candidate); This is log(Level level, String msg, Object param1), and it does not require guards — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1112 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYz9lzYykafmYxfJx5XCZP4dF5X5OvJks5tUao6gaJpZM4SD2T2> .

[jesperpedersen]

I agree that the big win is for log statements with arguments, however Logger.log() does an internal if (enabled), so this saves 1 function call per log statement.

Feel free to close.

[davecramer]

sounds to me like it costs 1 function call to save 1 function call ? Dave Cramer

…

On 13 February 2018 at 10:39, Jesper Pedersen ***@***.***> wrote: I agree that the big win is for log statements with arguments, however Logger.log() does an internal if (enabled), so this saves 1 function call per log statement. Feel free to close. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYz9hjFI49pZ8R7BVo3NKbR4DvAJykuks5tUayzgaJpZM4SD2T2> .

[jesperpedersen]

Logger.isLoggable vs Logger.log() + Logger.isLoggable()