New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix JavaDoc for getPreferQueryMode() #1122

Merged
merged 1 commit into from Feb 18, 2018

Conversation

Projects
None yet
4 participants
@bpd0018
Contributor

bpd0018 commented Feb 17, 2018

Update the JavaDoc to show that the return type is PreferQueryMode rather than boolean.

docs: fix JavaDoc for getPreferQueryMode()
Update the JavaDoc to show that the return type is PreferQueryMode rather than boolean.
@codecov-io

This comment has been minimized.

codecov-io commented Feb 17, 2018

Codecov Report

Merging #1122 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1122      +/-   ##
============================================
- Coverage     67.26%   67.25%   -0.02%     
+ Complexity     3669     3668       -1     
============================================
  Files           170      170              
  Lines         15632    15632              
  Branches       2528     2528              
============================================
- Hits          10515    10513       -2     
- Misses         3930     3931       +1     
- Partials       1187     1188       +1

@vlsi vlsi added this to the 42.2.2 milestone Feb 18, 2018

@vlsi vlsi merged commit 43d80cd into pgjdbc:master Feb 18, 2018

1 of 2 checks passed

codecov/project 67.25% (-0.02%) compared to 8ff2a61
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -204,12 +204,14 @@
String escapeLiteral(String literal) throws SQLException;
/**
* Returns true if the connection is configured to use "simple 'Q' execute" commands only
* When running in simple protocol only, certain features are not available: callable statements,
* Returns the query mode for this connection.

This comment has been minimized.

@davecramer

davecramer Feb 20, 2018

Member

I'm not sure this is going in the right direction. We are providing less information in this version of the documentation than what was there. If anything providing a link or more description of the modes would be preferable to me.

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

docs: fix JavaDoc for getPreferQueryMode() (pgjdbc#1122)
Update the JavaDoc to show that the return type is PreferQueryMode rather than boolean.

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

docs: fix JavaDoc for getPreferQueryMode() (pgjdbc#1122)
Update the JavaDoc to show that the return type is PreferQueryMode rather than boolean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment