New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allowEncodingChanges should allow set client_encoding=... #1125

Merged
merged 4 commits into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@vlsi
Member

vlsi commented Feb 18, 2018

fixes #1101

@vlsi vlsi added this to the 42.2.2 milestone Feb 18, 2018

@vlsi vlsi requested a review from davecramer Feb 18, 2018

vlsi added some commits Feb 18, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Mar 8, 2018

Codecov Report

Merging #1125 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1125      +/-   ##
============================================
+ Coverage     67.25%   67.35%   +0.09%     
- Complexity     3678     3685       +7     
============================================
  Files           170      170              
  Lines         15643    15638       -5     
  Branches       2533     2531       -2     
============================================
+ Hits          10521    10533      +12     
+ Misses         3930     3921       -9     
+ Partials       1192     1184       -8

@vlsi vlsi merged commit af64ed2 into pgjdbc:master Mar 8, 2018

2 checks passed

codecov/project 67.35% (+0.09%) compared to 1ca0c58
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dkaelbling

This comment has been minimized.

dkaelbling commented Mar 8, 2018

I might be misreading the commit diffs, but did you also just remove support for setting "standard_conforming_strings"?

Also please don't emit a warning; callers already know they're doing something special by setting "allow_encoding_changes". Alarming all the users won't help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment