fix: allowEncodingChanges should allow set client_encoding=... #1125
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
============================================
+ Coverage 67.25% 67.35% +0.09%
- Complexity 3678 3685 +7
============================================
Files 170 170
Lines 15643 15638 -5
Branches 2533 2531 -2
============================================
+ Hits 10521 10533 +12
+ Misses 3930 3921 -9
+ Partials 1192 1184 -8 |
I might be misreading the commit diffs, but did you also just remove support for setting "standard_conforming_strings"? Also please don't emit a warning; callers already know they're doing something special by setting "allow_encoding_changes". Alarming all the users won't help :-) |
rhavermans
added a commit
to bolcom/pgjdbc
that referenced
this pull request
Jul 13, 2018
rhavermans
added a commit
to bolcom/pgjdbc
that referenced
this pull request
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #1101