New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling mistake correction #1181

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
3 participants
@kommiharibabu
Contributor

kommiharibabu commented May 4, 2018

:s/vesions/versions

Hari Babu
spelling mistake correction
:s/vesions/versions

@davecramer davecramer merged commit e88abd7 into pgjdbc:master May 4, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@vlsi

This comment has been minimized.

Member

vlsi commented May 4, 2018

@davecramer , @kommiharibabu , please refrain from changing localized strings alone.
The string has been wildly used: https://github.com/pgjdbc/pgjdbc/search?utf8=%E2%9C%93&q=%22SCRAM+authentication+is+not+supported%22&type=

@davecramer

This comment has been minimized.

Member

davecramer commented May 4, 2018

@vlsi do you want to revert this and then fix it properly ?

@vlsi

This comment has been minimized.

Member

vlsi commented May 4, 2018

I think a subsequent commit that patches the rest files would be the least surprising sequence.

@kommiharibabu kommiharibabu deleted the kommiharibabu:spelling_correction branch May 4, 2018

@kommiharibabu

This comment has been minimized.

Contributor

kommiharibabu commented May 4, 2018

@vlsi Sorry about that, I wasn't aware to send the update the po and class files also, I thought those will be updated once for the release?

I did mvn -Ptransalte compile to update all the PO files.

Can I generate another pull request? Or Do you want me update only the *.po files for that message only?

@davecramer

This comment has been minimized.

Member

davecramer commented May 4, 2018

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment