Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link to GitHub documentation #1191

Merged
merged 1 commit into from May 17, 2018
Merged

docs: fix link to GitHub documentation #1191

merged 1 commit into from May 17, 2018

Conversation

@bersace
Copy link
Contributor

@bersace bersace commented May 16, 2018

Hi,

GitHub help links for contributing are broken This commit update the two links to point to new GitHub guides.

Thanks !

Old links are dead and uses clear-text HTTP links. This commit update the two
links to point to new GitHub guides.
@codecov-io
Copy link

@codecov-io codecov-io commented May 16, 2018

Codecov Report

Merging #1191 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1191      +/-   ##
============================================
- Coverage     69.15%   69.14%   -0.01%     
+ Complexity     3796     3795       -1     
============================================
  Files           171      171              
  Lines         15766    15766              
  Branches       2578     2578              
============================================
- Hits          10903    10902       -1     
  Misses         3621     3621              
- Partials       1242     1243       +1
@jorsol
Copy link
Member

@jorsol jorsol commented May 17, 2018

LGTM

@bersace
Copy link
Contributor Author

@bersace bersace commented May 17, 2018

@jorsol thanks. Should i add [skip ci] in commit message ?

@vlsi vlsi added this to the 42.2.3 milestone May 17, 2018
@vlsi vlsi merged commit 655b6e7 into pgjdbc:master May 17, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/project 69.14% (-0.01%) compared to f78a639
Details
@vlsi
Copy link
Member

@vlsi vlsi commented May 17, 2018

Should i add [skip ci] in commit message ?

It is clear that CI failure in this case has nothing to do with the proposed changes. There's no hard constraint for CI to pass in that cases.
On the other hand, you might save some Travis resources by adding [skip ci]

@bersace bersace deleted the bersace:deadlinks branch May 17, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Old links are dead and uses clear-text HTTP links. This commit update the two
links to point to new GitHub guides.
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Old links are dead and uses clear-text HTTP links. This commit update the two
links to point to new GitHub guides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants