New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: drop openj9 unstable build #1196

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
4 participants
@jorsol
Contributor

jorsol commented May 19, 2018

The AdoptOpenJDK project does not yet provide a stable build for JDK9+ using OpenJ9, the current production-ready build is based on OpenJDK8.

So it don't actually provide any benefit to test with openj9 since most installs are based on oraclejdk or openjdk and most Java implementations should pass the JCK anyway, this will help to reduce the matrix complexity and the time it takes to run the tests.

test: drop openj9 unstable build
The AdoptOpenJDK project does not yet provide a stable build for JDK9+ using OpenJ9, the current production-ready build is based on OpenJDK8 and most Java implementations should pass the JCK, so it don't actually provide any benefit to test with openj9 since most installs are based on oraclejdk or openjdk, this will help to reduce the matrix complexity and the time it takes to run the tests.
@codecov-io

This comment has been minimized.

codecov-io commented May 19, 2018

Codecov Report

Merging #1196 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1196      +/-   ##
============================================
- Coverage     69.24%   69.23%   -0.02%     
  Complexity     3804     3804              
============================================
  Files           171      171              
  Lines         15766    15766              
  Branches       2578     2578              
============================================
- Hits          10917    10915       -2     
- Misses         3613     3614       +1     
- Partials       1236     1237       +1
@bokken

This comment has been minimized.

Member

bokken commented May 19, 2018

+1

@vlsi vlsi added this to the 42.2.3 milestone May 21, 2018

@vlsi vlsi merged commit 9b6506d into pgjdbc:master May 21, 2018

1 of 2 checks passed

codecov/project 69.23% (-0.02%) compared to 2f9fed4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

test: drop OpenJ9 CI tests (pgjdbc#1196)
The AdoptOpenJDK project does not yet provide a stable build for JDK9+ using OpenJ9, the current production-ready build is based on OpenJDK8 and most Java implementations should pass the JCK, so it don't actually provide any benefit to test with openj9 since most installs are based on oraclejdk or openjdk, this will help to reduce the matrix complexity and the time it takes to run the tests.

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

test: drop OpenJ9 CI tests (pgjdbc#1196)
The AdoptOpenJDK project does not yet provide a stable build for JDK9+ using OpenJ9, the current production-ready build is based on OpenJDK8 and most Java implementations should pass the JCK, so it don't actually provide any benefit to test with openj9 since most installs are based on oraclejdk or openjdk, this will help to reduce the matrix complexity and the time it takes to run the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment