Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support parenthesis in {oj ...} JDBC escape syntax #865 #1204

Merged
merged 15 commits into from Jun 4, 2018
Merged

fix: support parenthesis in {oj ...} JDBC escape syntax #865 #1204

merged 15 commits into from Jun 4, 2018

Conversation

@AlBundy33
Copy link
Contributor

@AlBundy33 AlBundy33 commented May 28, 2018

see #865

@codecov-io
Copy link

@codecov-io codecov-io commented May 31, 2018

Codecov Report

Merging #1204 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1204      +/-   ##
============================================
+ Coverage     69.21%   69.25%   +0.04%     
- Complexity     3803     3806       +3     
============================================
  Files           171      171              
  Lines         15766    15767       +1     
  Branches       2578     2578              
============================================
+ Hits          10912    10920       +8     
+ Misses         3616     3613       -3     
+ Partials       1238     1234       -4
@davecramer davecramer added this to the 42.2.3 milestone Jun 2, 2018
* @throws Exception on error
*/
private void testOuterJoinSyntax(final String theQuery, List<String> theExpectedColumns) throws Exception {
final Statement _st = connection.createStatement();

This comment has been minimized.

@vlsi

vlsi Jun 2, 2018
Member

@AlBundy33 , underscore-based names are not used in pgjdbc.

@vlsi vlsi changed the title Test outer join syntax as supported up to 9.4.1211 #865 fix: support parenthesis in {oj ...} JDBC escape syntax #865 Jun 4, 2018
@vlsi vlsi merged commit 38356e6 into pgjdbc:master Jun 4, 2018
2 checks passed
2 checks passed
codecov/project 69.25% (+0.04%) compared to 9b6506d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AlBundy33 AlBundy33 deleted the AlBundy33:OuterJoinSyntax branch Jun 4, 2018
@bokken bokken mentioned this pull request Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants