Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support query timeouts exceeding 2147483 seconds (~25 days) #1224

Merged
merged 1 commit into from Jun 22, 2018

Conversation

@vlsi
Copy link
Member

@vlsi vlsi commented Jun 21, 2018

Use long field for timeout to avoid unexpected "Query timeout must be a value greater than or equals to 0" when query timeout exceeds 2147483=Integer.MAX_VALUE/1000

fixes #1223

Use long field for timeout to avoid unexpected
"Query timeout must be a value greater than or equals to 0" when query timeout exceeds 2147483

fixes #1223
@vlsi vlsi added this to the 42.2.3 milestone Jun 21, 2018
@davecramer
Copy link
Member

@davecramer davecramer commented Jun 21, 2018

LGTM

@codecov-io
Copy link

@codecov-io codecov-io commented Jun 21, 2018

Codecov Report

Merging #1224 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1224      +/-   ##
============================================
+ Coverage     69.25%   69.27%   +0.02%     
- Complexity     3810     3813       +3     
============================================
  Files           171      171              
  Lines         15786    15790       +4     
  Branches       2582     2583       +1     
============================================
+ Hits          10933    10939       +6     
+ Misses         3616     3615       -1     
+ Partials       1237     1236       -1
@vlsi vlsi merged commit b7fd9f3 into pgjdbc:master Jun 22, 2018
2 checks passed
2 checks passed
codecov/project 69.27% (+0.02%) compared to a699965
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
…dbc#1224)

Use long field for timeout to avoid unexpected
"Query timeout must be a value greater than or equals to 0" when query timeout exceeds 2147483

fixes pgjdbc#1223
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
…dbc#1224)

Use long field for timeout to avoid unexpected
"Query timeout must be a value greater than or equals to 0" when query timeout exceeds 2147483

fixes pgjdbc#1223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.