New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove obsolete outParmBeforeFunc #1234

Merged
merged 1 commit into from Jul 1, 2018

Conversation

Projects
None yet
4 participants
@benbenw
Contributor

benbenw commented Jun 30, 2018

remove it

@vlsi

This comment has been minimized.

Member

vlsi commented Jun 30, 2018

Looks good

@davecramer

This comment has been minimized.

Member

davecramer commented Jun 30, 2018

Looks good to me, reminded me that we have to rewrite this code for #1235

@codecov-io

This comment has been minimized.

codecov-io commented Jul 1, 2018

Codecov Report

Merging #1234 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #1234      +/-   ##
============================================
- Coverage     68.68%   68.67%   -0.01%     
  Complexity     3834     3834              
============================================
  Files           173      173              
  Lines         16000    15993       -7     
  Branches       2609     2609              
============================================
- Hits          10989    10983       -6     
  Misses         3780     3780              
+ Partials       1231     1230       -1

@vlsi vlsi changed the title from outParmBeforeFunc is not used to refactor: remove obsolete outParmBeforeFunc Jul 1, 2018

@vlsi vlsi added this to the 42.2.3 milestone Jul 1, 2018

@vlsi vlsi merged commit 7102853 into pgjdbc:master Jul 1, 2018

2 checks passed

codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +14.65% compared to 83f2e38
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment