Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 42.2.3 #1238

Merged
merged 3 commits into from Jul 11, 2018

Conversation

Projects
None yet
5 participants
@vlsi
Copy link
Member

vlsi commented Jul 2, 2018

This is a draft release notes for 42.2.3

@vlsi vlsi force-pushed the vlsi:release_notes_42.2.3 branch from badffe0 to ab33af1 Jul 2, 2018

@vlsi vlsi changed the title Release notes 42.2.3 Release notes for 42.2.3 Jul 2, 2018

@vlsi vlsi added this to the 42.2.3 milestone Jul 2, 2018

### Fixed

## [42.2.3] (2018-07-04)
### Changed
- Avoid the print of highest logger levels when the exception is re-thrown. [PR 1187](https://github.com/pgjdbc/pgjdbc/pull/1187)

This comment has been minimized.

Copy link
@davecramer

davecramer Jul 3, 2018

Member

Ironically this isn't even in the PR but the language here is poor.

**Notable changes**

### Changed
- Avoid the print of highest logger levels when the exception is re-thrown. [PR 1187](https://github.com/pgjdbc/pgjdbc/pull/1187)

This comment has been minimized.

Copy link
@davecramer

davecramer Jul 3, 2018

Member

I've put a PR into rewrite this log message

@vlsi vlsi force-pushed the vlsi:release_notes_42.2.3 branch from ab33af1 to 00058b2 Jul 3, 2018

- Deprecate Fastpath API [PR 903](https://github.com/pgjdbc/pgjdbc/pull/903)
- Support parenthesis in {oj ...} JDBC escape syntax [PR 1204](https://github.com/pgjdbc/pgjdbc/pull/1204)
- ubenchmark module moved pgjdbc/benchmarks repository due to licensing issues [PR 1215](https://github.com/pgjdbc/pgjdbc/pull/1215)
- Improved CONTRIBUTING.md [PR 951](https://github.com/pgjdbc/pgjdbc/pull/951)

This comment has been minimized.

Copy link
@jorsol

jorsol Jul 3, 2018

Contributor

The release notes (CHANGELOG.md) should include only Notable changes, I think that something like "Improved CONTRIBUTING.md" is not "Notable"

This comment has been minimized.

Copy link
@vlsi

vlsi Jul 4, 2018

Author Member

I think How to submit a bug report is notable for end-users.

This comment has been minimized.

Copy link
@jorsol

jorsol Jul 4, 2018

Contributor

Ok, fair enough 🙂

In that case something like "Include section how to submit a bug report in CONTRIBUTING.md" is more descriptive.

@bokken

This comment has been minimized.

Copy link
Member

bokken commented Jul 3, 2018

@vlsi vlsi force-pushed the vlsi:release_notes_42.2.3 branch from 00058b2 to 615bdd6 Jul 5, 2018

"trtrmitya" : "https://github.com/trtrmitya",
"zapov" : "https://github.com/zapov",
"Álvaro Hernández Tortosa" : "https://github.com/ahachete",
"Étienne BERSAC" : "https://github.com/bersace"

This comment has been minimized.

Copy link
@vlsi

vlsi Jul 5, 2018

Author Member

Apparently there is utf-8 kind of issue with release_notes_filter.pl to be fixed, however the rest should be fine

[Sidi Mohamed EL AATIFI](https://github.com/elaatifi)
[Stephen Nelson](https://github.com/lordnelson)
[Vladimir Sitnikov](https://github.com/vlsi)
[bazzargh](https://github.com/bazzargh)

This comment has been minimized.

Copy link
@vlsi

vlsi Jul 5, 2018

Author Member

It looks like the sorting is case-sensitive. I'm not sure if case-insensitive would be better or not

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 5, 2018

Codecov Report

Merging #1238 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #1238      +/-   ##
===========================================
+ Coverage     68.68%   68.7%   +0.01%     
- Complexity     3847    3849       +2     
===========================================
  Files           174     174              
  Lines         16035   16035              
  Branches       2614    2614              
===========================================
+ Hits          11014   11017       +3     
+ Misses         3782    3780       -2     
+ Partials       1239    1238       -1

@vlsi vlsi force-pushed the vlsi:release_notes_42.2.3 branch from 615bdd6 to 9ee5412 Jul 6, 2018

@vlsi vlsi added the needs-review label Jul 6, 2018

vlsi added some commits Jul 1, 2018

@vlsi vlsi force-pushed the vlsi:release_notes_42.2.3 branch from 9ee5412 to 592a48c Jul 10, 2018

@vlsi vlsi removed the needs-review label Jul 10, 2018

@vlsi

This comment has been minimized.

Copy link
Member Author

vlsi commented Jul 10, 2018

I assume this is fine for merge as well. If you see issues please step in. Otherwise I'm going to merge this and push 42.2.3

@vlsi vlsi force-pushed the vlsi:release_notes_42.2.3 branch from 592a48c to 706a96e Jul 11, 2018

@vlsi vlsi merged commit 706a96e into pgjdbc:master Jul 11, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@davecramer

This comment has been minimized.

Copy link
Member

davecramer commented on 671913b Jul 11, 2018

shouldn't the comment be 42.2.3 ?

This comment has been minimized.

Copy link
Member Author

vlsi replied Jul 11, 2018

that is a typo indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.