Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor language updates #1241

Merged
merged 2 commits into from Jul 3, 2018
Merged

minor language updates #1241

merged 2 commits into from Jul 3, 2018

Conversation

@davecramer
Copy link
Member

@davecramer davecramer commented Jul 3, 2018

No description provided.

@@ -5,7 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## [Unreleased]
### Changed
- Avoid the print of highest logger levels when the exception is re-thrown. [PR 1187](https://github.com/pgjdbc/pgjdbc/pull/1187)
- Reduce the severity of the erorr log messages when an exception is re-thrown. We have already logged the

This comment has been minimized.

@vlsi

vlsi Jul 3, 2018
Member

We have already logged the error

That is not true.

Actual case is "the error will be thrown to upper level, and it would likely log it/act accordingly", so no need to log it with high severity at pgjdbc side.

@codecov-io
Copy link

@codecov-io codecov-io commented Jul 3, 2018

Codecov Report

Merging #1241 into master will increase coverage by 0.02%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #1241      +/-   ##
============================================
+ Coverage     68.68%   68.71%   +0.02%     
- Complexity     3834     3835       +1     
============================================
  Files           173      173              
  Lines         15996    15996              
  Branches       2609     2609              
============================================
+ Hits          10987    10991       +4     
+ Misses         3778     3775       -3     
+ Partials       1231     1230       -1
@vlsi vlsi added this to the 42.2.3 milestone Jul 3, 2018
@vlsi
Copy link
Member

@vlsi vlsi commented Jul 3, 2018

LGTM

@davecramer davecramer merged commit e19ee7a into pgjdbc:master Jul 3, 2018
2 checks passed
2 checks passed
codecov/project 68.71% (+0.02%) compared to f4ae60e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davecramer davecramer deleted the davecramer:cleanmessages branch Jul 3, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
* reword the commit message correctly
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
* reword the commit message correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.