Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: remove editor backup files #1255
Conversation
vlsi
added this to the 42.3.0 milestone
Jul 18, 2018
vlsi
added this to In progress
in 42.3.0 Release
via automation
Jul 18, 2018
vlsi
changed the title from
Remove editor backup files
to
chore: remove editor backup files
Jul 18, 2018
This comment has been minimized.
This comment has been minimized.
|
LGTM. Is the PR "feature complete"? Do you intend to remove more files?
Technically speaking we might want to update documentation build system so it creates proper cross-references for various pgdbc versions. However I haven't heard if anyone wanted to do that. |
This comment has been minimized.
This comment has been minimized.
|
@vlsi: The PR is complete, yes. |
vlsi
merged commit b1b1afb
into
pgjdbc:master
Jul 18, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
42.3.0 Release
automation
moved this from In progress
to Done
Jul 18, 2018
added a commit
to golovnin/pgjdbc
that referenced
this pull request
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ChristophBerg commentedJul 18, 2018
These are removed by the Debian package build in the "clean" step and
pop up as uncommitted changes.
On a side node, the "92" and "93" directories in the doc/documentation directory are identical and could be merged, and documentation.md in the same place has dangling references to versions 80 till 91.