New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove editor backup files #1255

Merged
merged 1 commit into from Jul 18, 2018

Conversation

2 participants
@ChristophBerg
Contributor

ChristophBerg commented Jul 18, 2018

These are removed by the Debian package build in the "clean" step and
pop up as uncommitted changes.

On a side node, the "92" and "93" directories in the doc/documentation directory are identical and could be merged, and documentation.md in the same place has dangling references to versions 80 till 91.

Remove editor backup files
These are removed by the Debian package build in the "clean" step and
pop up as uncommitted changes.

@vlsi vlsi added this to the 42.3.0 milestone Jul 18, 2018

@vlsi vlsi added this to In progress in 42.3.0 Release via automation Jul 18, 2018

@vlsi vlsi changed the title from Remove editor backup files to chore: remove editor backup files Jul 18, 2018

@vlsi

This comment has been minimized.

Member

vlsi commented Jul 18, 2018

LGTM. Is the PR "feature complete"? Do you intend to remove more files?

On a side node, the "92" and "93" directories in the doc/documentation directory are identical and could be merged,

Technically speaking we might want to update documentation build system so it creates proper cross-references for various pgdbc versions. However I haven't heard if anyone wanted to do that.

@ChristophBerg

This comment has been minimized.

Contributor

ChristophBerg commented Jul 18, 2018

@vlsi: The PR is complete, yes.

@vlsi vlsi merged commit b1b1afb into pgjdbc:master Jul 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

42.3.0 Release automation moved this from In progress to Done Jul 18, 2018

golovnin added a commit to golovnin/pgjdbc that referenced this pull request Jul 24, 2018

chore: remove editor backup files (pgjdbc#1255)
These are removed by the Debian package build in the "clean" step and
pop up as uncommitted changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment