New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move issue template and pull request template into github specific di… #1283

Merged
merged 2 commits into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@davecramer
Member

davecramer commented Jul 30, 2018

…rectory

@vlsi

This comment has been minimized.

Member

vlsi commented Jul 30, 2018

Technically speaking the only way to test these kind of changes is to merge the PR.

So we have two options:

  1. Just merge it and see what happens. If we are lucky it will just work. If not, we'll clutter history/mails for everyone :)
  2. We can test the changes in throwaway repos. For instance, I've just set vlsi/pgjdbc master branch to your PR, and issue template seems to work: https://github.com/vlsi/pgjdbc/issues/new
@vlsi

This comment has been minimized.

Member

vlsi commented Jul 30, 2018

In order for checklist to work, no whitespace should exist at the start of the lines

- [ ] bug report
- [ ] feature request
@codecov-io

This comment has been minimized.

codecov-io commented Jul 30, 2018

Codecov Report

Merging #1283 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1283   +/-   ##
=========================================
  Coverage     68.75%   68.75%           
- Complexity     3854     3855    +1     
=========================================
  Files           174      174           
  Lines         16029    16029           
  Branches       2612     2612           
=========================================
  Hits          11021    11021           
- Misses         3776     3777    +1     
+ Partials       1232     1231    -1

@davecramer davecramer merged commit b5c19af into pgjdbc:master Jul 30, 2018

2 checks passed

codecov/project 68.75% remains the same compared to c66bf71
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment