Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix wrong secondaryPort2 build property #1284

Merged
merged 1 commit into from Nov 28, 2018

Conversation

4 participants
@jorsol
Copy link
Contributor

commented Aug 1, 2018

The secondaryServerPort2 is misspelled in the build.properties file and do not match with the one used in MultiHostsConnectionTest.java. Also make secondaryServer1 and secondaryPort1 consistent in the naming.

@davecramer

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

I'm confused. Where is this spelled wrong ?

@jorsol

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2018

Probably it's not clear in the PR, but the property file have secondaryServerPort2 and the MultiHostsConnectionTest looks for secondaryPort2, since I was testing a docker setup of patroni, the port of all instances are 5432, but the test suite fails trying to connect to port 5434, which is the default.

To be more clear, the MultiHostsConnectionTest fails because it can not connect to port 5434, since my environment is configured to connect to port 5432, in build.local.properties.

Maybe misspelled is not the right word, but it points to the wrong parameter name.

@jorsol jorsol changed the title test: fix misspelled secondaryPort2 build property test: fix wrong secondaryPort2 build property Aug 1, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Aug 1, 2018

Codecov Report

Merging #1284 into master will increase coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1284      +/-   ##
============================================
+ Coverage     68.49%   68.76%   +0.26%     
+ Complexity     3868     3854      -14     
============================================
  Files           178      174       -4     
  Lines         16184    16029     -155     
  Branches       2639     2612      -27     
============================================
- Hits          11086    11022      -64     
+ Misses         3865     3775      -90     
+ Partials       1233     1232       -1
@vlsi

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

LGTM

@vlsi vlsi added this to the 42.3.0 milestone Aug 1, 2018

@vlsi vlsi added this to In progress in 42.3.0 Release via automation Aug 1, 2018

@davecramer davecramer merged commit 2c0f692 into pgjdbc:master Nov 28, 2018

2 checks passed

codecov/project 68.76% (+0.26%) compared to b53eedf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

42.3.0 Release automation moved this from In progress to Done Nov 28, 2018

@jorsol jorsol deleted the jorsol:fix-secondaryPort-property branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.