Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for version 11 and version 12 #1332

Merged
merged 5 commits into from Nov 22, 2018
Merged

Conversation

@davecramer
Copy link
Member

@davecramer davecramer commented Nov 6, 2018

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 6, 2018

Codecov Report

Merging #1332 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1332      +/-   ##
============================================
- Coverage     68.58%   68.56%   -0.03%     
+ Complexity     3883     3881       -2     
============================================
  Files           178      178              
  Lines         16205    16207       +2     
  Branches       2646     2646              
============================================
- Hits          11114    11112       -2     
- Misses         3860     3863       +3     
- Partials       1231     1232       +1

@jorsol
Copy link
Member

@jorsol jorsol commented Nov 7, 2018

Hi Dave, I see that there are some tests to check the server version already:
https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/test/java/org/postgresql/test/util/ServerVersionTest.java
https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/test/java/org/postgresql/test/util/ServerVersionParseTest.java

Maybe merge your test with those instead of having yet another test class?

@davecramer
Copy link
Member Author

@davecramer davecramer commented Nov 7, 2018

@jorsol thanks, I'll move my tests into there.

@davecramer davecramer merged commit 7f0e200 into pgjdbc:master Nov 22, 2018
2 checks passed
@davecramer davecramer deleted the addversion11 branch Nov 22, 2018
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
* Add support for version 11 and version 12

* add tests for ServerVersion

* remove core.ServerVersionTest, move tests into util.ServerVersionTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants