Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setURL in BaseDataSource #1341

Merged
merged 2 commits into from Nov 22, 2018

Conversation

Projects
None yet
2 participants
@davecramer
Copy link
Member

commented Nov 17, 2018

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [ Y] Does your submission pass tests?
  2. [ Y] Does mvn checkstyle:check pass ?

Changes to Existing Features:

  • [ N] Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ Y] Have you written new tests for your core changes, as applicable?
  • [ Y] Have you successfully run tests with your changes locally?
@codecov-io

This comment has been minimized.

Copy link

commented Nov 17, 2018

Codecov Report

Merging #1341 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1341      +/-   ##
============================================
- Coverage     68.58%   68.55%   -0.03%     
  Complexity     3883     3883              
============================================
  Files           178      178              
  Lines         16205    16207       +2     
  Branches       2646     2647       +1     
============================================
- Hits          11114    11111       -3     
- Misses         3860     3864       +4     
- Partials       1231     1232       +1

@davecramer davecramer merged commit 2ad1ac3 into pgjdbc:master Nov 22, 2018

2 checks passed

codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +31.41% compared to f3ade07
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davecramer davecramer deleted the davecramer:fixseturl branch Nov 22, 2018

@dinoGH dinoGH referenced this pull request Jun 19, 2019

Closed

NullPointerException by typo in URL protocol prefix #1338

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.