Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing documents, and point to jackdb/pgjdbc-test-vm #1363

Merged
merged 5 commits into from Dec 8, 2018

Conversation

Projects
None yet
4 participants
@sualeh
Copy link
Contributor

commented Dec 6, 2018

Update testing documents, and point to jackdb/pgjdbc-test-vm

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
@sualeh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2018

@davecramer - I have got @sehrope pgjdbc-test-vm working! This pull request is to update the documentation to make it easy for others. Hopefully, we can get contributors to write more tests.

@codecov-io

This comment has been minimized.

Copy link

commented Dec 6, 2018

Codecov Report

Merging #1363 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1363      +/-   ##
============================================
- Coverage     68.68%   68.67%   -0.01%     
  Complexity     3893     3893              
============================================
  Files           179      179              
  Lines         16398    16398              
  Branches       2670     2670              
============================================
- Hits          11263    11262       -1     
- Misses         3886     3887       +1     
  Partials       1249     1249
@sehrope

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2018

+1 to linking to the test README from the CONTRIBUTING docs. I didn't even know there was a separate README for the tests as it's deep in the directory structure.

Crazy how out of date it is too. This line made me laugh:

Of course, you need to have a Java 2 JDK or JRE installed. The standard JDK from Sun is OK. You can download it from http://java.sun.com/.

Java 2 (i.e. Java 1.4) was released in 2002, Sun no longer exists, that link redirects to an Oracle page, and Oracle doesn't provide free JDKs anymore. Just a tad bit out of date...

That should be updated that to reference the same JDK requirements as the core driver (6+) by either linking to the main README or including the same info.

@davecramer

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

So apparently we are the only ones that read it....

@sualeh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2018

@davecramer - are we good to merge?

@sualeh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2018

So apparently we are the only ones that read it....

Hopefully, if more people read the documentation, more people will write tests...

sualeh added some commits Dec 7, 2018

@sualeh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2018

@davecramer - please review one more time. I have moved the file out of the source folder into root, where it is more accessible.

@davecramer davecramer merged commit 2a715a9 into pgjdbc:master Dec 8, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/project 68.67% (-0.01%) compared to 7be21fc
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.