Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor: Clean up loading of reading of keydata file in LazyKeyManager #1372
The old code does ensure that the RAF is closed though it's a bit difficult to reason about it as it happens in two different places depending on where an exception occurs. I took a peek at it after seeing #1371.
This PR refactors loading of keyfile data in LazyKeyManager a bit so that IO happens in a separate method and there is only one close operation. This also has the positive side effect of removing one of the
referenced this pull request
Dec 11, 2018
@@ Coverage Diff @@ ## master #1372 +/- ## ============================================ + Coverage 68.68% 68.71% +0.03% - Complexity 3892 3894 +2 ============================================ Files 179 179 Lines 16396 16393 -3 Branches 2670 2668 -2 ============================================ + Hits 11261 11264 +3 + Misses 3887 3881 -6 Partials 1248 1248