Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/chore: Add DEADLOCK_DETECTED Enumeration #1380

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@deanmarc25
Copy link
Contributor

commented Jan 2, 2019

include an additional value to represent the PostgreSQL error code for the condition "deadlock_detected". This is used for client error handling code, similar to (I assume), OBJECT_IN_USE

This is a personal issue that I came across today when attempting to handle deadlock exceptions, I am trying to avoid hard coding error codes in the applications.

All Submissions:

  • [X ] Have you followed the guidelines in our Contributing document?
  • [X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Add DEADLOCK_DETECTED Enumeration
This commit includes an additional value to represent the PostgreSQL error code for the condition "deadlock_detected".

- Include enum value for DEADLOCK_DETECTED PSQLState
- Set value to "40P01" per documentation located at: https://www.postgresql.org/docs/current/errcodes-appendix.html
@codecov-io

This comment has been minimized.

Copy link

commented Jan 2, 2019

Codecov Report

Merging #1380 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1380      +/-   ##
============================================
+ Coverage     68.71%   68.72%   +<.01%     
  Complexity     3894     3894              
============================================
  Files           179      179              
  Lines         16393    16394       +1     
  Branches       2668     2668              
============================================
+ Hits          11264    11266       +2     
+ Misses         3881     3880       -1     
  Partials       1248     1248

@davecramer davecramer merged commit a7f63bf into pgjdbc:master Jan 7, 2019

2 checks passed

codecov/project 68.72% (+<.01%) compared to 10945e3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@deanmarc25 deanmarc25 deleted the deanmarc25:add_deadlock_sql_state branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.