Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add StaticVariableName checkstyle rule #1414

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
5 participants
@AlexElin
Copy link
Contributor

commented Feb 18, 2019

add StaticVariableName checkstyle rule + fix violations + simplify SSPIClient constructor

chore: add StaticVariableName checkstyle rule
add StaticVariableName checkstyle rule + fix violations + simplify SSPIClient constructor
@AppVeyorBot

This comment has been minimized.

Copy link

commented Feb 18, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 18, 2019

Codecov Report

Merging #1414 into master will increase coverage by 0.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #1414      +/-   ##
============================================
+ Coverage     68.72%   68.74%   +0.01%     
  Complexity     3895     3895              
============================================
  Files           179      179              
  Lines         16400    16396       -4     
  Branches       2669     2668       -1     
============================================
  Hits          11271    11271              
+ Misses         3882     3878       -4     
  Partials       1247     1247
@bokken

bokken approved these changes Feb 20, 2019

Copy link
Member

left a comment

some of these changes are technically not passive. presumably, however, no consumer should be changing any of these values.

@davecramer davecramer merged commit ddb38e5 into pgjdbc:master Feb 21, 2019

3 checks passed

codecov/project 68.74% (+0.01%) compared to 4cd3f05
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.