Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add StaticVariableName checkstyle rule #1414

Merged
merged 1 commit into from Feb 21, 2019

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Feb 18, 2019

add StaticVariableName checkstyle rule + fix violations + simplify SSPIClient constructor

add StaticVariableName checkstyle rule + fix violations + simplify SSPIClient constructor
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Feb 18, 2019

Loading

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 18, 2019

Codecov Report

Merging #1414 into master will increase coverage by 0.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #1414      +/-   ##
============================================
+ Coverage     68.72%   68.74%   +0.01%     
  Complexity     3895     3895              
============================================
  Files           179      179              
  Lines         16400    16396       -4     
  Branches       2669     2668       -1     
============================================
  Hits          11271    11271              
+ Misses         3882     3878       -4     
  Partials       1247     1247

Loading

bokken
bokken approved these changes Feb 20, 2019
Copy link
Member

@bokken bokken left a comment

some of these changes are technically not passive. presumably, however, no consumer should be changing any of these values.

Loading

@davecramer davecramer merged commit ddb38e5 into pgjdbc:master Feb 21, 2019
3 checks passed
Loading
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
add StaticVariableName checkstyle rule + fix violations + simplify SSPIClient constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants