Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method alias's for each property which didn't use the conventiona… #1436

Merged
merged 2 commits into from Apr 19, 2019

Conversation

Projects
None yet
4 participants
@Tostino
Copy link
Contributor

commented Mar 12, 2019

…l Java bean method naming for the specific property name.

This allows other libraries like connection pools to properly set any properties by the property names through their own interface when you may not have direct access to the jdbc datasource.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
Add method alias's for each property which didn't use the conventiona…
…l Java bean method naming for the specific property name.

This allows other libraries like connection pools to properly set any properties by the property names through their own interface when you may not have direct access to the jdbc datasource.

@Tostino Tostino referenced this pull request Mar 12, 2019

Open

sslmode vs sslMode getter/setter case mismatch #1401

1 of 2 tasks complete
@AppVeyorBot

This comment has been minimized.

Copy link

commented Mar 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

Merging #1436 into master will increase coverage by 0.06%.
The diff coverage is 77.27%.

@@             Coverage Diff              @@
##             master    #1436      +/-   ##
============================================
+ Coverage     68.74%   68.81%   +0.06%     
- Complexity     3902     3931      +29     
============================================
  Files           179      179              
  Lines         16414    16459      +45     
  Branches       2672     2674       +2     
============================================
+ Hits          11284    11326      +42     
- Misses         3882     3887       +5     
+ Partials       1248     1246       -2
@AppVeyorBot

This comment has been minimized.

Copy link

commented Apr 18, 2019

@davecramer davecramer merged commit 0efcf81 into pgjdbc:master Apr 19, 2019

3 checks passed

codecov/project 68.81% (+0.06%) compared to 0c5cf47
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.