Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Cleanup encoding #1441
New Feature Submissions:
Changes to Existing Features:
Was taking a look at the internals of the string decoder to see what would be involved in supporting a "Use system decoder if longer than X... (as a possible alternative to #1433) and noticed a couple minor things to clean up.
PR is split into three commits:
That third commit also removes the
I've got a separate PR built atop this one that splits out
@@ Coverage Diff @@ ## master #1441 +/- ## ============================================ + Coverage 68.63% 68.75% +0.12% - Complexity 3896 3903 +7 ============================================ Files 179 179 Lines 16414 16414 Branches 2672 2672 ============================================ + Hits 11266 11286 +20 + Misses 3895 3880 -15 + Partials 1253 1248 -5
@adeopujariarkin It does not fix that issue. This is some general cleanup and optimization I put together while looking into options for the large string decoding. I put it up as a separate PR because there was not consensus yet on how to address the large string decoding and the changes in this PR are generic improvements that need not wait for that.