Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove extra empty lines #1454

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
7 participants
@kazachka
Copy link
Contributor

commented Apr 1, 2019

In addition to #1452
Apologies, but I forgot to remove some extra empty lines in previous PR.
In addition I add rule to disallow multiple empty lines to checks.xml.

@AppVeyorBot

This comment has been minimized.

Copy link

commented Apr 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #1454 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1454   +/-   ##
=========================================
  Coverage     68.74%   68.74%           
  Complexity     3903     3903           
=========================================
  Files           179      179           
  Lines         16414    16414           
  Branches       2672     2672           
=========================================
  Hits          11284    11284           
  Misses         3883     3883           
  Partials       1247     1247
@davecramer

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@kazachka this doesn't pass our checkstyle step..

@kazachka kazachka force-pushed the kazachka:master branch from c64808c to 76d3dde Apr 2, 2019

@AppVeyorBot

This comment has been minimized.

Copy link

commented Apr 2, 2019

@jorsol

jorsol approved these changes Apr 2, 2019

@kazachka

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Checkstyle violations fixed.
In the meantime I have changed checkstyle PR. It will check empty lines before comments only if allowMultipleEmptyLines set to false.
It means even if this PR is not merged, you won't have checkstyle violations anyway.
So this PR can be merged, if you find it useful, otherwise it can be closed.

@bokken

bokken approved these changes Apr 16, 2019

Copy link
Member

left a comment

+1

@vlsi vlsi merged commit cb466d1 into pgjdbc:master Apr 19, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.