Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution with big decimal in simple query mode. #1463

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@kaiwangchen
Copy link
Contributor

commented Apr 8, 2019

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
    Yes.
  2. Does mvn checkstyle:check pass ?
    Yes.

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
    Nop.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    Big decimal is set as string without cast, which is parsed as T_String instead of T_Float in postgres, resulting improper operator match thus conversion error.
  • Have you written new tests for your core changes, as applicable?
    Yes, see enclosed.
  • Have you successfully run tests with your changes locally?
    mvn test passed in local env.
@AppVeyorBot

This comment has been minimized.

Copy link

commented Apr 8, 2019

@fuyufjh

This comment has been minimized.

Copy link

commented Apr 9, 2019

Fixes #1464

@davecramer davecramer merged commit 8e47a30 into pgjdbc:master Apr 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.