Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix javadoc for defaultAutoCommit to default to true #1465

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@davecramer
Copy link
Member

commented Apr 9, 2019

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@davecramer davecramer merged commit 0a4f078 into pgjdbc:master Apr 9, 2019

@davecramer davecramer deleted the davecramer:fixjavadoc branch Apr 9, 2019

@sehrope

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

s/off/on/ right?

   * default value is <tt>true</tt>, so that autoCommit will be turned off by default.
@davecramer

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Ha, thanks for catching that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.