Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven coordinates #1479

Merged
merged 1 commit into from Jun 17, 2019

Conversation

Projects
None yet
4 participants
@davecramer
Copy link
Member

commented May 1, 2019

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
@AppVeyorBot

This comment has been minimized.

Copy link

commented May 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #1479 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #1479      +/-   ##
===========================================
- Coverage     68.81%   68.8%   -0.01%     
+ Complexity     3931    3930       -1     
===========================================
  Files           179     179              
  Lines         16459   16459              
  Branches       2674    2674              
===========================================
- Hits          11326   11325       -1     
+ Misses         3888    3887       -1     
- Partials       1245    1247       +2

@davecramer davecramer merged commit 45ce14f into master Jun 17, 2019

4 of 5 checks passed

codecov/project 68.8% (-0.01%) compared to 95ba7b2
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@davecramer davecramer deleted the davecramer-patch-2 branch Jun 17, 2019

@@ -230,7 +230,7 @@ TL;DR:

Note: the artifacts will not be visible in Maven Central before you manually release them.

1. Navigate to [Sonatype Nexus Repository Manager](https://oss.sonatype.org/#stagingRepositories), find staging `orgpostgresql` repository there and release it
1. Navigate to [Sonatype Nexus Repository Manager](https://oss.sonatype.org/#stagingRepositories), find staging `org.postgresql` repository there and release it

This comment has been minimized.

Copy link
@vlsi

vlsi Jun 17, 2019

Member

This is an invalid change. The repository in question is named like orgpostgresql rather than org.postgresql

@davecramer

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

davecramer added a commit that referenced this pull request Jun 18, 2019

davecramer added a commit that referenced this pull request Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.