Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info about currentSchema property #1481

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@vskaiman
Copy link
Contributor

@vskaiman vskaiman commented May 14, 2019

Add in documentation that currentSchema property can be multiple
fixes #1480

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from 13682b1 to b1564cd May 14, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 14, 2019

Build pgjdbc 1.0.248 completed (commit 9a398f6 by @vsevolodk)

Loading

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 14, 2019

Build pgjdbc 1.0.249 completed (commit 4609f07 by @vsevolodk)

Loading

@codecov-io
Copy link

@codecov-io codecov-io commented May 14, 2019

Codecov Report

Merging #1481 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1481      +/-   ##
============================================
+ Coverage      68.8%   68.82%   +0.02%     
- Complexity     3936     3937       +1     
============================================
  Files           179      179              
  Lines         16466    16467       +1     
  Branches       2674     2674              
============================================
+ Hits          11330    11334       +4     
+ Misses         3890     3888       -2     
+ Partials       1246     1245       -1

Loading

@davecramer
Copy link
Member

@davecramer davecramer commented May 15, 2019

@vsevolodk thanks for this. I think instead of "via comma" the comments should be "separated by comma's"
There's no need to change the connect.md in 94
It would be great if you added a test case.

Thanks!

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented May 15, 2019

It would be great if you added a test case.

Test case how I use several schema?

Loading

@davecramer
Copy link
Member

@davecramer davecramer commented May 15, 2019

Yes, we are stating that setSchema supports multiple paths. The test case would prove that it does.

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from b1564cd to b7b69de May 15, 2019
@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented May 15, 2019

The test case would prove that it does.

Are you expect junit test? Or some description is enough ?

Loading

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 15, 2019

Build pgjdbc 1.0.250 completed (commit d24c25f by @vsevolodk)

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from b7b69de to 8abe477 May 15, 2019
@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented May 15, 2019

I added new tests using currentSchema property

Loading

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 15, 2019

Build pgjdbc 1.0.251 completed (commit 12321a2 by @vsevolodk)

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch 2 times, most recently from c4fb1bf to 8357b4f May 15, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 15, 2019

Build pgjdbc 1.0.252 completed (commit e3101ac by @vsevolodk)

Loading

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 15, 2019

Build pgjdbc 1.0.253 completed (commit 4454fe9 by @vsevolodk)

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented May 16, 2019

@davecramer now tests are required external postgres instance.
Do you think about using https://www.testcontainers.org/ and https://www.testcontainers.org/modules/databases/postgres/ ?
We use it for our tests and it great works. We can up different configuration of postgres for several unit tests, example max_connection and etc.

Loading

@davecramer
Copy link
Member

@davecramer davecramer commented May 16, 2019

@vsevolodk it's been brought up before. Personally I have no use for it as at any given time I have access to multiple versions of postgres. If you want to propose it in a different PR I can look at it. We've certainly had requests for it.

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented May 16, 2019

Ok, I'll check later. What about current PR about currentSchema?

Loading

@davecramer
Copy link
Member

@davecramer davecramer commented May 16, 2019

@vsevolodk other than moving execute into TestUtil, it looks great!

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from 8357b4f to 455d5dc May 16, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 16, 2019

Build pgjdbc 1.0.254 completed (commit 97e9017 by @vsevolodk)

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented May 17, 2019

Someone else should do review?

Loading

@davecramer
Copy link
Member

@davecramer davecramer commented May 17, 2019

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from 455d5dc to a3fb258 May 17, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 17, 2019

Build pgjdbc 1.0.255 completed (commit af3b8af by @vsevolodk)

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented May 17, 2019

How to retry build? Unchanged test was failed. Tests are do rollback in db after execute? May be table creation and function can affect logical replication in another test cases?

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented Jun 23, 2019

@davecramer, @vlsi hi.
What about this PR? Will you merge it?

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from a3fb258 to 1f0edf9 Jun 23, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 23, 2019

Build pgjdbc 1.0.314 completed (commit dcf6fba by @vsevolodk)

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from 1f0edf9 to 2597799 Jun 24, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 24, 2019

Build pgjdbc 1.0.319 completed (commit 3a22a05 by @vsevolodk)

Loading

@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from 2597799 to 31a99e8 Jun 24, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 24, 2019

Build pgjdbc 1.0.320 completed (commit dfe11b0 by @vsevolodk)

Loading

README.md Outdated Show resolved Hide resolved
Loading
@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from 31a99e8 to aaa6331 Jun 24, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 24, 2019

Build pgjdbc 1.0.321 completed (commit 57c3195 by @vsevolodk)

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented Jun 24, 2019

Loading

@vlsi
Copy link
Member

@vlsi vlsi commented Jun 25, 2019

@vsevolodk , unfortunately retry does not help there.
Apparently something had happened with Trusty+oraclejdk11

Loading

Add in documentation that currentSchema property can be multiple
and fixed behavior by tests.
@vskaiman vskaiman force-pushed the doc/add_currentSchema_info branch from aaa6331 to ccb396d Jun 27, 2019
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 27, 2019

Build pgjdbc 1.0.323 completed (commit 89f6fe6 by @vsevolodk)

Loading

@vskaiman
Copy link
Contributor Author

@vskaiman vskaiman commented Jun 27, 2019

Fresh push still does not work, but previously build was success and after I changed only commas.
@vlsi @davecramer @jorsol do you have any points about this PR?
May be you can already accept and merge it?

Loading

@davecramer
Copy link
Member

@davecramer davecramer commented Jun 28, 2019

@vsevolodk if nobody objects overnight I'll push it tomorrow

Loading

@davecramer davecramer merged commit d96ed59 into pgjdbc:master Jun 28, 2019
2 of 3 checks passed
Loading
@vskaiman vskaiman deleted the doc/add_currentSchema_info branch Jun 28, 2019
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
Add in documentation that currentSchema property can be multiple
and fix test behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants