Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error messages cannot be formatted #1492

Merged
merged 2 commits into from May 30, 2019

Conversation

Projects
None yet
4 participants
@davecramer
Copy link
Member

commented May 29, 2019

fixes #1491

@AppVeyorBot

This comment has been minimized.

Copy link

commented May 29, 2019

@vlsi

This comment has been minimized.

message files should be updated as well :-/

This comment has been minimized.

Copy link
Member Author

replied May 29, 2019

will do

@codecov-io

This comment has been minimized.

Copy link

commented May 29, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@17c4bcf). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #1492   +/-   ##
=========================================
  Coverage          ?   68.81%           
  Complexity        ?     3930           
=========================================
  Files             ?      179           
  Lines             ?    16458           
  Branches          ?     2672           
=========================================
  Hits              ?    11326           
  Misses            ?     3887           
  Partials          ?     1245
@AppVeyorBot

This comment has been minimized.

Copy link

commented May 29, 2019

@davecramer davecramer merged commit 12ef697 into master May 30, 2019

3 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davecramer davecramer deleted the davecramer-fix-1491 branch May 30, 2019

@vlsi

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

I'm afraid this is invalid change.

messages_xx.java files are autogenerated (see comment at the very first line), so all edits to those files would be silently reverted by msgfmt.

Translations should be updated via editing of *.po files ,then mvn -Ptranslate compile like described in https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md#updating-translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.