Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error messages cannot be formatted #1492

Merged
merged 2 commits into from May 30, 2019
Merged

fix: Error messages cannot be formatted #1492

merged 2 commits into from May 30, 2019

Conversation

@davecramer
Copy link
Member

@davecramer davecramer commented May 29, 2019

fixes #1491

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 29, 2019

vlsi
Copy link
Member

vlsi commented on c5d97fc May 29, 2019

message files should be updated as well :-/

davecramer
Copy link
Member

davecramer commented on c5d97fc May 29, 2019

will do

@codecov-io
Copy link

@codecov-io codecov-io commented May 29, 2019

Codecov Report

No coverage uploaded for pull request base (master@17c4bcf). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #1492   +/-   ##
=========================================
  Coverage          ?   68.81%           
  Complexity        ?     3930           
=========================================
  Files             ?      179           
  Lines             ?    16458           
  Branches          ?     2672           
=========================================
  Hits              ?    11326           
  Misses            ?     3887           
  Partials          ?     1245

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented May 29, 2019

@davecramer davecramer merged commit 12ef697 into master May 30, 2019
3 of 5 checks passed
@davecramer davecramer deleted the davecramer-fix-1491 branch May 30, 2019
@vlsi
Copy link
Member

@vlsi vlsi commented Jun 18, 2019

I'm afraid this is invalid change.

messages_xx.java files are autogenerated (see comment at the very first line), so all edits to those files would be silently reverted by msgfmt.

Translations should be updated via editing of *.po files ,then mvn -Ptranslate compile like described in https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md#updating-translations

davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
* fix: Error messages cannot be formatted

fixes pgjdbc#1491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants