Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1499 rounding for timestamps truncated to dates before 1970 #1502

Merged
merged 4 commits into from Jun 17, 2019

Conversation

@davecramer
Copy link
Member

@davecramer davecramer commented Jun 14, 2019

See subject

@davecramer davecramer mentioned this pull request Jun 14, 2019
2 tasks
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 14, 2019

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 14, 2019

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 16, 2019

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Jun 17, 2019

@davecramer davecramer merged commit c9a7078 into pgjdbc:master Jun 17, 2019
2 checks passed
@@ -1232,7 +1232,12 @@ public Date convertToDate(long millis, TimeZone tz) {
if (tz == null) {
tz = getDefaultTz();
}
if (isSimpleTimeZone(tz.getID())) {
/*
the following math does not work for negative times
Copy link
Member

@vlsi vlsi Jun 18, 2019

It looks like floorDiv supercedes this comment

@davecramer davecramer deleted the fixnegativetimestamp branch Dec 16, 2019
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
pgjdbc#1502)

* fix pgjdbc#1499 rounding for timestamps truncated to dates before 1970

* Implement floorDiv until we drop support for Java 1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants