Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note on behavior of ResultSet.getString() (#1286) #1528

Merged
merged 6 commits into from Jul 19, 2019

Conversation

@mshajarrazip
Copy link
Contributor

commented Jul 17, 2019

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
@AppVeyorBot

This comment has been minimized.

Copy link

commented Jul 17, 2019

the currently open `ResultSet` instance is closed automatically.
* When PreparedStatement API is used, `ResultSet` switches to binary mode after

This comment has been minimized.

Copy link
@bokken

bokken Jul 17, 2019

Member

I would suggest making this a bit more generic. Something to the effect of the result of calling getString for data types which are not strings is not guaranteed. While results will be logically equivalent, the format may be inconsistent based things like backend string representation vs. binary mode or even if a complex type (such as an array) has been converted into object form.

This comment has been minimized.

Copy link
@mshajarrazip

mshajarrazip Jul 17, 2019

Author Contributor

Thanks for the suggestion. Working on this.

@AppVeyorBot

This comment has been minimized.

Copy link

commented Jul 17, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 17, 2019

Codecov Report

Merging #1528 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1528      +/-   ##
============================================
+ Coverage     68.81%   68.94%   +0.13%     
- Complexity     3941     3953      +12     
============================================
  Files           179      179              
  Lines         16480    16480              
  Branches       2676     2676              
============================================
+ Hits          11340    11362      +22     
+ Misses         3891     3873      -18     
+ Partials       1249     1245       -4
@AppVeyorBot

This comment has been minimized.

Copy link

commented Jul 18, 2019

@AppVeyorBot

This comment has been minimized.

Copy link

commented Jul 18, 2019

@AppVeyorBot

This comment has been minimized.

Copy link

commented Jul 18, 2019

the set `prepareThreshold` when conversion to object method switches to one
matching the return mode.

This comment has been minimized.

Copy link
@davecramer

davecramer Jul 18, 2019

Member

@mshajarrazip thanks for this. Looks good to me!

This comment has been minimized.

Copy link
@mshajarrazip

mshajarrazip Jul 18, 2019

Author Contributor

You're welcome :-)

@davecramer davecramer merged commit c30556c into pgjdbc:master Jul 19, 2019

3 checks passed

codecov/project 68.94% (+0.13%) compared to 08d8129
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mshajarrazip mshajarrazip deleted the mshajarrazip:Issue_1286 branch Jul 21, 2019

@davecramer

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

I hadn't noticed this before but this changes the the 94 documentation not head. Can you also update https://github.com/pgjdbc/pgjdbc/tree/master/docs/documentation/head

mshajarrazip added a commit to mshajarrazip/pgjdbc that referenced this pull request Jul 30, 2019
davecramer added a commit that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.