Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure isValid() will not last more than timeout seconds #1557
Now all tests succeed, but theoritically I should :
@@ Coverage Diff @@ ## master #1557 +/- ## ============================================ - Coverage 68.92% 68.88% -0.04% Complexity 3971 3971 ============================================ Files 179 179 Lines 16545 16569 +24 Branches 2695 2695 ============================================ + Hits 11403 11414 +11 - Misses 3890 3902 +12 - Partials 1252 1253 +1
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.