Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow OUT parameter registration when using CallableStatement na… #1561

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@gregn123
Copy link
Contributor

gregn123 commented Sep 5, 2019

…tive CALL

Currently, using CallableStatement, the PGJDBC driver will allow invocation of procedures using
the native "call myproc(...)" syntax, provided the procedure only has IN parameters or no
parameters.
However, if the procedure has any INOUT parameters, then an attempt to invoke the
CallableStatement's registerOutParameter() method, which is required in order to register the OUT
part of the INOUT parameter, will fail with the following error:
This statement does not declare an OUT parameter. Use { ?= call ... } to declare one.

This fixes issue: #1545

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Sep 5, 2019

…tive CALL

Currently, using CallableStatement, the PGJDBC driver will allow invocation of procedures using
the native "call myproc(...)" syntax, provided the procedure only has IN parameters or no
parameters.
However, if the procedure has any INOUT parameters, then an attempt to invoke the
CallableStatement's registerOutParameter() method, which is required in order to register the OUT
part of the INOUT parameter, will fail with the following error:
   This statement does not declare an OUT parameter.  Use { ?= call ... } to declare one.

This fixes issue: #1545
@gregn123 gregn123 force-pushed the gregn123:master branch from b3d536d to 3162d5b Sep 5, 2019
@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Sep 5, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #1561 into master will increase coverage by 0.11%.
The diff coverage is 37.5%.

@@             Coverage Diff              @@
##             master    #1561      +/-   ##
============================================
+ Coverage     68.94%   69.05%   +0.11%     
- Complexity     4032     4042      +10     
============================================
  Files           179      179              
  Lines         16750    16758       +8     
  Branches       2740     2744       +4     
============================================
+ Hits          11549    11573      +24     
+ Misses         3931     3917      -14     
+ Partials       1270     1268       -2
@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 26, 2019

@davecramer davecramer merged commit ed74670 into pgjdbc:master Nov 26, 2019
3 checks passed
3 checks passed
codecov/project 69.05% (+0.11%) compared to 7b45435
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.