Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite order #1593

Merged
merged 3 commits into from Oct 29, 2019
Merged

Fix test suite order #1593

merged 3 commits into from Oct 29, 2019

Conversation

@sehrope
Copy link
Contributor

sehrope commented Oct 28, 2019

Fixes sort order for some test suites so we have cleaner diffs down the road.

Would be nice to have a checkstyle rule or equivalent to enforce this but at the moment we don't run any style checks on src/test/ anyway so I've just added a few words to the PR template.

@sehrope

This comment has been minimized.

Copy link
Contributor Author

sehrope commented Oct 28, 2019

I also noticed that SSPITestSuite is empty, I don't think anything actually executes SSPITest:

//@RunWith(Suite.class)
//@Suite.SuiteClasses({ SSPITest.class })
public class SSPITestSuite {
// Empty.
}

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Oct 28, 2019

@davecramer davecramer merged commit 003ea83 into pgjdbc:master Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.